Skip to content

Commit 5bfc5cd

Browse files
reduced loading time for popout graph windows (#1116)
* reduced loading time for popout graph windows * made handler resiliant according to copilot comments * linters
1 parent 7956356 commit 5bfc5cd

3 files changed

Lines changed: 8 additions & 1 deletion

File tree

gcs/electron/modules/graphWindow.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ export function openGraphWindow(
9292
frame: true,
9393
icon: path.join(process.env.VITE_PUBLIC!, "app_icon.ico"),
9494
show: false,
95+
backgroundColor: "#282c34",
9596
title: meta?.title ?? "Graph",
9697
webPreferences: {
9798
preload: path.join(__dirname, "preload.js"),

gcs/electron/preload.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,12 @@ const { appendLoading, removeLoading } = useLoading()
226226
domReady().then(appendLoading)
227227

228228
window.onmessage = (ev) => {
229-
ev.data.payload === "removeLoading" && removeLoading()
229+
if (!ev || ev.data == null || typeof ev.data !== "object") {
230+
return
231+
}
232+
if (ev.data.payload === "removeLoading") {
233+
removeLoading()
234+
}
230235
}
231236

232237
setTimeout(removeLoading, 4999)

gcs/src/graphWindow.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ export default function GraphWindowApp() {
6868
// tell main we are ready *after* listeners exist
6969
if (!sentReadyRef.current) {
7070
window.ipcRenderer.send("app:graph-window:ready")
71+
window.postMessage({ payload: "removeLoading" }, "*")
7172
sentReadyRef.current = true
7273
}
7374

0 commit comments

Comments
 (0)