Skip to content

Commit 821ad9e

Browse files
authored
Display param definition in FLA params window (#1137)
* Display param definition in FLA params window * Address copilot review comments
1 parent c4ff350 commit 821ad9e

2 files changed

Lines changed: 21 additions & 1 deletion

File tree

gcs/electron/modules/flaParamsWindow.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export function openFlaParamsWindow(
1919
}
2020

2121
const windowOptions: Electron.BrowserWindowConstructorOptions = {
22-
width: 800,
22+
width: 1100,
2323
height: 1200,
2424
frame: true,
2525
icon: path.join(process.env.VITE_PUBLIC, "app_icon.ico"),
@@ -55,7 +55,9 @@ export function openFlaParamsWindow(
5555
flaParamsWin.on("close", () => {
5656
flaParamsWin = null
5757
})
58+
5859
flaParamsWin.setMenuBarVisibility(false)
60+
flaParamsWin.center()
5961
flaParamsWin.show()
6062

6163
if (paramsData !== null) {

gcs/src/components/fla/flaParamsWindow.jsx

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,18 @@ function renderParamValue(value, paramDef) {
8181
)
8282
}
8383

84+
function getParamDefinitionText(paramDef) {
85+
if (!paramDef || typeof paramDef !== "object") {
86+
return null
87+
}
88+
89+
if (typeof paramDef.Description === "string" && paramDef.Description.trim()) {
90+
return paramDef.Description
91+
}
92+
93+
return null
94+
}
95+
8496
export default function FlaParamsWindow() {
8597
const [params, setParams] = useState(null)
8698
const [fileName, setFileName] = useState("")
@@ -190,6 +202,7 @@ export default function FlaParamsWindow() {
190202
<Table.Tr>
191203
<Table.Th className="w-56">Parameter</Table.Th>
192204
<Table.Th className="w-40">Value</Table.Th>
205+
<Table.Th>Definition</Table.Th>
193206
</Table.Tr>
194207
</Table.Thead>
195208
<Table.Tbody>
@@ -205,6 +218,11 @@ export default function FlaParamsWindow() {
205218
<Table.Td>
206219
{renderParamValue(param.value, paramDefs[param.name])}
207220
</Table.Td>
221+
<Table.Td>
222+
<div className="max-h-24 overflow-y-auto">
223+
{getParamDefinitionText(paramDefs[param.name])}
224+
</div>
225+
</Table.Td>
208226
</Table.Tr>
209227
))}
210228
</Table.Tbody>

0 commit comments

Comments
 (0)