Add clear mission button to context menu (#603)

* Add clear mission button to context menu

* Clear mission for all mission types

* Fix no waypoints mission test

* Fix test again

Author: 1Blademaster

gcs/src/components/missions/missionsMap.jsx

@@ -54,6 +54,7 @@ function MapSectionNonMemo({
   markerDragEndCallback,
   addNewMissionItem,
   updateMissionHomePosition,
+  clearMissionItems,
   mapId = "dashboard",
 }) {
   const [connected] = useSessionStorage({
@@ -347,6 +348,11 @@ function MapSectionNonMemo({
                 <p>Set home position</p>
               </div>
             </ContextMenuItem>
+            <ContextMenuItem onClick={clearMissionItems}>
+              <div className="w-full flex justify-between gap-2">
+                <p>Clear mission</p>
+              </div>
+            </ContextMenuItem>
           </div>
         )}
       </Map>

gcs/src/missions.jsx

@@ -528,6 +528,24 @@ export default function Missions() {
     }
   }
 
+  function clearMissionItems() {
+    if (activeTab === "mission") {
+      // Clear all mission items except the first if the first is a home position
+      if (
+        missionItems.length > 0 &&
+        isGlobalFrameHomeCommand(missionItems[0])
+      ) {
+        setMissionItems([missionItems[0]])
+      } else {
+        setMissionItems([])
+      }
+    } else if (activeTab === "fence") {
+      setFenceItems([])
+    } else if (activeTab === "rally") {
+      setRallyItems([])
+    }
+  }
+
   return (
     <Layout currentPage="missions">
       {/* Banner to let people know that things are still under development */}
@@ -644,6 +662,7 @@ export default function Missions() {
                   markerDragEndCallback={updateMissionItem}
                   addNewMissionItem={addNewMissionItem}
                   updateMissionHomePosition={updateMissionHomePosition}
+                  clearMissionItems={clearMissionItems}
                   mapId="missions"
                 />
               </div>

radio/app/controllers/missionController.py

@@ -498,16 +498,20 @@ def uploadMission(self, mission_type: int, waypoints: List[dict]) -> Response:
 
         new_loader = self._parseWaypointsListIntoLoader(waypoints, mission_type)
 
-        if new_loader.count() == 0:
-            return {
-                "success": False,
-                "message": f"No waypoints loaded for the mission type of {mission_type}",
-            }
-
         clear_mission_response = self.clearMission(mission_type)
         if not clear_mission_response.get("success"):
             return clear_mission_response
 
+        # If the loader is empty, we don't need to upload anything.
+        if new_loader.count() == 0:
+            self.drone.logger.info(
+                f"Cleared mission type {mission_type}, no waypoints to upload"
+            )
+            return {
+                "success": True,
+                "message": f"Cleared mission type {mission_type}, no waypoints to upload",
+            }
+
         self.drone.is_listening = False
 
         self.drone.master.mav.mission_count_send(

radio/tests/test_mission.py

@@ -409,6 +409,6 @@ def test_writeCurrentMission_correctState_noWaypoints(
 
     assert socketio_result["name"] == "write_mission_result"
     assert socketio_result["args"][0] == {
-        "success": False,
-        "message": "No waypoints loaded for the mission type of 0",
+        "success": True,
+        "message": "Cleared mission type 0, no waypoints to upload",
     }