856 recent logs list shows incorrect time (#873)

* manually save last opened time

* Revert "manually save last opened time"

This reverts commit 9613526.

* changed format of recentLogs.json to include timestamp

* formatting

* applying copilots suggestions

Author: Kwash67

gcs/electron/fla.ts

@@ -26,6 +26,7 @@ import type {
   MessageObject,
   Messages,
   ParseResult,
+  RecentLog,
 } from "./types/flaTypes"
 
 import {
@@ -408,7 +409,7 @@ async function determineLogFileType(filePath: string): Promise<LogType> {
 }
 
 // New function to get recent files
-export function getRecentFiles(): string[] {
+export function getRecentFiles(): RecentLog[] {
   return recentLogsManager.getRecentLogs()
 }
 

gcs/electron/main.ts

@@ -501,16 +501,22 @@ app.whenReady().then(() => {
           `Expected recentLogs to be an array, but got ${typeof recentLogs}`,
         )
       }
-      return recentLogs.map((logPath) => {
-        const logName = path.basename(logPath)
-        const fileStats = fs.statSync(logPath)
-        return {
-          name: logName,
-          path: logPath,
-          size: fileStats.size,
-          timestamp: fileStats.mtime,
-        }
-      })
+      return recentLogs
+        .map((log) => {
+          try {
+            const logName = path.basename(log.path)
+            const fileStats = fs.statSync(log.path)
+            return {
+              name: logName,
+              path: log.path,
+              size: fileStats.size,
+              timestamp: new Date(log.timestamp),
+            }
+          } catch {
+            return null
+          }
+        })
+        .filter((log) => log !== null)
     } catch (error) {
       return []
     }

gcs/electron/types/flaTypes.ts

@@ -107,3 +107,8 @@ export type LogType =
   | "fgcs_telemetry"
   | "mp_telemetry"
   | null
+
+export interface RecentLog {
+  path: string
+  timestamp: number
+}

gcs/electron/utils/recentLogManager.ts

@@ -1,6 +1,7 @@
 import { app } from "electron"
 import * as fs from "fs"
 import * as path from "path"
+import type { RecentLog } from "../types/flaTypes"
 
 export default function createRecentLogsManager(maxRecentLogs: number = 10) {
   // JSON file to hold paths to recently opened logs
@@ -9,13 +10,38 @@ export default function createRecentLogsManager(maxRecentLogs: number = 10) {
     "recentLogs.json",
   )
 
-  function loadRecentLogs(): string[] {
+  function loadRecentLogs(): RecentLog[] {
     try {
       if (fs.existsSync(recentLogsPath)) {
         const data = fs.readFileSync(recentLogsPath, "utf8")
         const parsed = JSON.parse(data)
-        // Ensure we return an array of strings
-        return Array.isArray(parsed) ? parsed : []
+
+        // Backward compatibility: convert array of strings to array of objects
+        if (Array.isArray(parsed)) {
+          return parsed.map((item) => {
+            if (typeof item === "string") {
+              // Old format: use mtime as fallback
+              try {
+                const stats = fs.statSync(item)
+                return { path: item, timestamp: stats.mtime.getTime() }
+              } catch {
+                return { path: item, timestamp: Date.now() }
+              }
+            }
+            // New format: validate and return
+            if (
+              typeof item === "object" &&
+              item !== null &&
+              "path" in item &&
+              "timestamp" in item
+            ) {
+              return item as RecentLog
+            }
+            // Invalid format: treat as current time
+            return { path: String(item), timestamp: Date.now() }
+          })
+        }
+        return []
       }
       return []
     } catch (error) {
@@ -24,7 +50,7 @@ export default function createRecentLogsManager(maxRecentLogs: number = 10) {
     }
   }
 
-  let recentLogs: string[] = loadRecentLogs()
+  let recentLogs: RecentLog[] = loadRecentLogs()
 
   function saveRecentLogs(): void {
     try {
@@ -37,10 +63,10 @@ export default function createRecentLogsManager(maxRecentLogs: number = 10) {
   return {
     addRecentLog(filePath: string): void {
       // Remove the file if it already exists in the list
-      recentLogs = recentLogs.filter((file: string) => file !== filePath)
+      recentLogs = recentLogs.filter((log: RecentLog) => log.path !== filePath)
 
-      // Add the file to the beginning of the list
-      recentLogs.unshift(filePath)
+      // Add the file to the beginning of the list with current timestamp
+      recentLogs.unshift({ path: filePath, timestamp: Date.now() })
 
       // Trim the list if it exceeds the maximum allowed
       if (recentLogs.length > maxRecentLogs) {
@@ -49,10 +75,10 @@ export default function createRecentLogsManager(maxRecentLogs: number = 10) {
       saveRecentLogs()
     },
 
-    getRecentLogs(): string[] {
+    getRecentLogs(): RecentLog[] {
       // Filter out files that no longer exist
-      const existingFiles: string[] = recentLogs.filter((file: string) =>
-        fs.existsSync(file),
+      const existingFiles: RecentLog[] = recentLogs.filter((log: RecentLog) =>
+        fs.existsSync(log.path),
       )
 
       // Update the list if files were removed