Added mavlink forwarding to mac menu bar (#855)

* added mavlink forwarding to mac menu bar

* addressing copilot suggestion by replacing removeListener with removeAllListeners

Author: Kwash67

gcs/electron/main.ts

@@ -304,13 +304,6 @@ function setMainMenu() {
     {
       label: "View",
       submenu: [
-        {
-          label: "Connection Stats",
-          click: () => {
-            openLinkStatsWindow()
-          },
-        },
-        { type: "separator" },
         { role: "reload" },
         { role: "forceReload" },
         { role: "toggleDevTools" },
@@ -322,6 +315,23 @@ function setMainMenu() {
         { role: "togglefullscreen" },
       ],
     },
+    {
+      label: "Advanced",
+      submenu: [
+        {
+          label: "Connection Stats",
+          click: () => {
+            openLinkStatsWindow()
+          },
+        },
+        {
+          label: "MAVLink Forwarding",
+          click: () => {
+            win?.webContents.send("mavlink-forwarding:open")
+          },
+        },
+      ],
+    },
   ]
   const menu = Menu.buildFromTemplate(template)
   Menu.setApplicationMenu(menu)

gcs/electron/preload.js

@@ -58,6 +58,7 @@ const ALLOWED_ON_CHANNELS = [
   "app:send-ekf-status",
   "app:send-vibe-status",
   "settings:open",
+  "mavlink-forwarding:open",
 ]
 
 contextBridge.exposeInMainWorld("ipcRenderer", {

gcs/src/components/navbar.jsx

@@ -162,6 +162,13 @@ export default function Navbar() {
     }
   }, [comPorts, selectedComPort])
 
+  useEffect(() => {
+    const handler = () => dispatch(setForwardingAddressModalOpened(true))
+    window.ipcRenderer.on("mavlink-forwarding:open", handler)
+    return () =>
+      window.ipcRenderer.removeAllListeners("mavlink-forwarding:open")
+  }, [dispatch])
+
   const linkClassName =
     "text-md px-2 rounded-sm outline-none focus:text-falconred-400 hover:text-falconred-400 transition-colors delay-50"
 

gcs/src/helpers/settingsProvider.jsx

@@ -39,7 +39,7 @@ export const SettingsProvider = ({ children }) => {
   useEffect(() => {
     const handler = () => open()
     window.ipcRenderer.on("settings:open", handler)
-    return () => window.ipcRenderer.removeListener("settings:open", handler)
+    return () => window.ipcRenderer.removeAllListeners("settings:open")
   }, [open])
 
   const setSetting = (setting, value) => {