Attempt to set parameters 3 times by default (#1037)

* Attempt to set parameters 3 times by default

* Address copilot review comments

* Update param type

Author: 1Blademaster

radio/app/controllers/flightModesController.py

@@ -110,7 +110,7 @@ def setFlightMode(self, mode_number: int, flight_mode: int) -> Response:
                 }
             mode_name = mavutil.mavlink.enums["COPTER_MODE"][flight_mode].name
 
-        param_type = 2
+        param_type = mavutil.mavlink.MAV_PARAM_TYPE_UINT8
         param_set_success = self.drone.paramsController.setParam(
             f"FLTMODE{mode_number}", flight_mode, param_type
         )
@@ -145,7 +145,7 @@ def setFlightModeChannel(self, channel: int) -> Response:
                 "message": f"Invalid flight mode channel, must be between 1 and 16 inclusive, got {channel}.",
             }
 
-        param_type = 2
+        param_type = mavutil.mavlink.MAV_PARAM_TYPE_UINT8
         param_set_success = self.drone.paramsController.setParam(
             "FLTMODE_CH", channel, param_type
         )

radio/app/controllers/paramsController.py

@@ -320,10 +320,16 @@ def setParam(
             self.drone.logger.error("Could not reserve PARAM_VALUE messages")
             return False
 
+        # Ensure we try at least once
+        if retries <= 0:
+            retries = 1
+
+        retries_remaining = retries
+
         try:
             # Keep trying to set the parameter until we get an ack or run out of retries or timeout
-            while retries > 0 and not got_ack:
-                retries -= 1
+            while retries_remaining > 0 and not got_ack:
+                retries_remaining -= 1
                 self.drone.master.param_set_send(
                     param_name.upper(), vfloat, parm_type=param_type
                 )
@@ -347,13 +353,13 @@ def setParam(
                     elif abs(ack.param_value - param_value) > 0.0001:
                         # Use a small tolerance for float comparison
                         self.drone.logger.warning(
-                            f"Could not set {param_name} to {param_value}, keeping value as {ack.param_value} instead"
+                            f"Could not set {param_name} to {param_value}, keeping value as {ack.param_value} instead. Trying again {retries_remaining} times."
                         )
                         self.drone.logger.debug(
                             f"Ack: {ack.to_dict()}, param_name: {param_name}, param_value: {param_value}"
                         )
-                        saved_param = False
-                        break
+                        got_ack = False
+                        continue
                     else:
                         self.drone.logger.debug(
                             f"Got parameter saving ack for {param_name} for value {param_value}"
@@ -363,7 +369,9 @@ def setParam(
                         break
 
             if not got_ack:
-                self.drone.logger.error(f"timeout setting {param_name} to {vfloat}")
+                self.drone.logger.error(
+                    f"Timeout setting {param_name} to {vfloat}, attempted {retries} times."
+                )
 
             return saved_param
         except serial.serialutil.SerialException: