Fixed select file buttons#746
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the FileButton components with a native file dialog implementation using IPC communication between the renderer and main Electron processes. This change provides better control over file selection and removes dependencies on the Mantine FileButton component.
- Replaced FileButton components with Button components that trigger native file dialogs
- Added IPC handler for file selection in the main Electron process
- Simplified file import logic by removing state management for file tracking
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gcs/src/missions.jsx | Replaced FileButton with direct file dialog call and simplified import logic |
| gcs/src/components/fla/SelectFlightLog.jsx | Replaced FileButton with native file selection implementation |
| gcs/electron/preload.js | Added IPC channel permission for file selection |
| gcs/electron/main.ts | Added IPC handler for native file dialog functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
NexInfinite
approved these changes
Oct 4, 2025
Contributor
NexInfinite
left a comment
NexInfinite
left a comment
There was a problem hiding this comment.
All good except from the one comment, doesn't need to be in so I'll approve for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.