Skip to content

813 fix telemetry dashboard display padding#823

Merged
Matthew-Dobson merged 11 commits into
mainfrom
813-fix-telemetry-dashboard-display-padding
Nov 17, 2025
Merged

813 fix telemetry dashboard display padding#823
Matthew-Dobson merged 11 commits into
mainfrom
813-fix-telemetry-dashboard-display-padding

Conversation

@Matthew-Dobson
Copy link
Copy Markdown
Contributor

fixed jitter in telemetry dashboard by:
-adding fixed-width tabular digit value boxes & center alligning

verified visually with mock data

@Matthew-Dobson Matthew-Dobson linked an issue Nov 4, 2025 that may be closed by this pull request
@Matthew-Dobson Matthew-Dobson requested a review from a team November 4, 2025 20:46
@1Blademaster
Copy link
Copy Markdown
Member

image Does not resize correctly anymore

Comment thread gcs/src/components/dashboard/telemetrySection/telemetryValueDisplay.jsx Outdated
Comment thread gcs/src/components/dashboard/telemetrySection/telemetryValueDisplay.jsx Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the telemetry value display component to improve layout consistency and add accessibility features. The changes focus on separating title and value display with improved styling controls.

  • Restructured TelemetryValueDisplay from a single paragraph to separate title and value spans with configurable width
  • Added widthCh parameter for fixed-width value display to prevent layout shifts
  • Wrapped indicator components in flex-shrink-0 divs to prevent unwanted shrinking

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
telemetryValueDisplay.jsx Refactored component structure to use separate spans for title and value, added fixed-width parameter and aria-label for accessibility
telemetry.jsx Wrapped AttitudeIndicator and HeadingIndicator components in non-shrinking containers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread gcs/src/components/dashboard/telemetrySection/telemetryValueDisplay.jsx Outdated
Comment thread gcs/src/components/dashboard/telemetrySection/telemetryValueDisplay.jsx Outdated
@Matthew-Dobson Matthew-Dobson self-assigned this Nov 9, 2025
@Matthew-Dobson Matthew-Dobson requested a review from a team November 9, 2025 21:36
@1Blademaster
Copy link
Copy Markdown
Member

1Blademaster commented Nov 10, 2025

Before:
image

After: image

The text needs to be bigger and the indicators look like they've shrunk a bit (or its the padding, idk something feels off)?

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread gcs/src/components/dashboard/telemetrySection/telemetry.jsx Outdated
@Matthew-Dobson Matthew-Dobson merged commit 4ecc991 into main Nov 17, 2025
6 checks passed
@Matthew-Dobson Matthew-Dobson deleted the 813-fix-telemetry-dashboard-display-padding branch November 17, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix telemetry dashboard display padding

3 participants