Skip to content

Convert fla electron files to typescript#826

Merged
1Blademaster merged 3 commits into
mainfrom
825-convert-fla-electron-files-to-typescript
Nov 5, 2025
Merged

Convert fla electron files to typescript#826
1Blademaster merged 3 commits into
mainfrom
825-convert-fla-electron-files-to-typescript

Conversation

@1Blademaster

Copy link
Copy Markdown
Member

No description provided.

@1Blademaster 1Blademaster requested review from a team and Copilot November 5, 2025 19:21
@1Blademaster 1Blademaster linked an issue Nov 5, 2025 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the recentLogManager from JavaScript to TypeScript and adds comprehensive type definitions throughout the log parsing and analysis utilities. The migration includes:

  • Converting recentLogManager.js to recentLogManager.ts with proper type annotations
  • Adding extensive TypeScript interfaces and type definitions to fla-utils.ts
  • Updating fla.ts with complete type safety including interfaces for messages, formats, and parsing results
  • Removing obsolete references from tsconfig.json (the ../graphs directory and the old JS file path)

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
gcs/tsconfig.json Removed references to migrated recentLogManager.js file and unused ../graphs directory from TypeScript compilation includes
gcs/settings/recentLogManager.js Deleted JavaScript version of recent log manager (migrated to TypeScript)
gcs/electron/utils/recentLogManager.ts New TypeScript implementation with type annotations for parameters, return types, and internal state
gcs/electron/utils/fla-utils.ts Added comprehensive type definitions for all interfaces and added type annotations to all exported functions
gcs/electron/fla.ts Added type definitions for parsing functions and updated imports to reference the new TypeScript recentLogManager
Comments suppressed due to low confidence (1)

gcs/electron/fla.ts:30

  • The fields property should be typed as readonly string[] instead of string[] to prevent accidental mutations of the format message fields, which should be immutable after parsing. This is a duplicate interface with fla-utils.ts - consider exporting and reusing the interface from a single location.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Kwash67 Kwash67 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@1Blademaster 1Blademaster merged commit 6ba139a into main Nov 5, 2025
6 checks passed
@1Blademaster 1Blademaster deleted the 825-convert-fla-electron-files-to-typescript branch November 5, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert fla electron files to typescript

3 participants