Skip to content

Highlight config in navbar for all pages starting with config#839

Merged
Turnlings merged 2 commits into
mainfrom
838-fix-navbar-highlighting-for-config
Nov 7, 2025
Merged

Highlight config in navbar for all pages starting with config#839
Turnlings merged 2 commits into
mainfrom
838-fix-navbar-highlighting-for-config

Conversation

@Turnlings

Copy link
Copy Markdown
Contributor

Switches an === to startsWith

Copilot AI review requested due to automatic review settings November 6, 2025 22:23
@Turnlings Turnlings linked an issue Nov 6, 2025 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Config navigation link highlighting logic to use a prefix match instead of an exact match. This ensures the Config link remains highlighted when viewing any config sub-page (e.g., motor test, RC calibration, flight modes).

Key Changes:

  • Modified the active state check from exact equality to prefix matching using startsWith()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread gcs/src/components/navbar.jsx Outdated
@Turnlings Turnlings requested a review from Copilot November 6, 2025 22:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Turnlings Turnlings requested a review from a team November 6, 2025 22:34
@Turnlings Turnlings merged commit 781cfdb into main Nov 7, 2025
12 checks passed
@Turnlings Turnlings deleted the 838-fix-navbar-highlighting-for-config branch November 7, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix navbar highlighting for config

3 participants