833 add warning if connected to aircraft and try to quit fgcs#840
Merged
ProgramPhantom merged 12 commits intoNov 23, 2025
Merged
Conversation
1Blademaster
requested changes
Nov 8, 2025
Contributor
Author
|
Made the changes. Looks like there's some conflict because I took ages. Should I try to fix it? |
Contributor
Author
|
Oh hold on there's one more problem. No idea what this is complaining about have you seen it before? When I created a separate file for the confirm close modal, I initially had it as "ConfirmExitModal.jsx". I then changed it to "confirmExitModal.jsx" when I noticed that was the name scheme for jsx files, then this error appeared where I was importing it in toolbar.jsx. |
Contributor
Author
|
Nevermind it seems to have magically fixed after restarting my IDE! |
…-try-to-quit-fgcs
ProgramPhantom
deleted the
833-add-warning-if-connected-to-aircraft-and-try-to-quit-fgcs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new modal in the
toolbar.jsxfile, and connected it up to a new application slice in the redux store. Currently it only stores the state for this modal but it will probably be useful in the future.Popup simply requests the user reconsiders closing the application, but only when the drone is connected. A further suggestion like "something bad may happen to the drone" etc etc may be added to this area.