841 convert log bin files#842
Merged
Merged
Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for parsing binary dataflash (.bin) log files by integrating a dataflash parser and refactoring the type system to be more consistent across different log formats.
- Adds binary (.bin) file format support alongside existing text-based (.log) dataflash logs
- Refactors type definitions into a centralized types file for better maintainability
- Updates the log parsing pipeline to handle different file extensions and formats
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| gcs/src/components/fla/SelectFlightLog.jsx | Adds "bin" extension to the file picker for selecting binary dataflash logs |
| gcs/src/components/fla/constants.js | Removes unused constants (ignoredMessages and ignoredKeys) that have been relocated |
| gcs/electron/types/flaTypes.ts | Introduces centralized type definitions for FLA including MessageObject, FormatMessage, LogType, and other interfaces |
| gcs/electron/utils/flaUtils.ts | Moves type definitions to shared types file, relocates ignored message/key constants, removes unused unit caching functions, and adds file extension utility |
| gcs/electron/utils/dataflashParser.js | Adds complete binary dataflash parser based on external library for parsing .bin files |
| gcs/electron/utils/dataflashParserUtils.js | Adds utility functions to transform parser output into the expected format |
| gcs/electron/fla.ts | Refactors to support multiple log types, updates type references, adds bin file parsing logic, and converts unit/multiplier strings to arrays |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.