Skip to content

769 fix visual styling in params page#849

Merged
bensgilbert merged 8 commits into
mainfrom
769-fix-visual-styling-in-params-page
Nov 12, 2025
Merged

769 fix visual styling in params page#849
bensgilbert merged 8 commits into
mainfrom
769-fix-visual-styling-in-params-page

Conversation

@bensgilbert

Copy link
Copy Markdown
Contributor

No description provided.

@bensgilbert bensgilbert linked an issue Nov 10, 2025 that may be closed by this pull request
@bensgilbert bensgilbert self-assigned this Nov 10, 2025
@bensgilbert bensgilbert requested a review from a team November 10, 2025 03:34
@1Blademaster 1Blademaster requested a review from Copilot November 10, 2025 07:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the params page UI by introducing a resizable sidebar for parameter actions and reorganizing the toolbar. The main changes include moving write/refresh/save/load buttons from the horizontal toolbar into a new left sidebar, updating the API for adding modified params to accept arrays instead of objects, and streamlining the toolbar to focus on search and filtering functionality.

  • Introduced a resizable sidebar using ResizableBox for parameter action buttons
  • Moved param operations (refresh, write, save, load) from toolbar to sidebar
  • Fixed appendModifiedParams to consistently accept arrays instead of objects

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
gcs/src/params.jsx Added resizable sidebar with action buttons, implemented refreshCallback and saveParamsToFile functions, restructured layout with new flex container hierarchy
gcs/src/components/params/valueInput.jsx Fixed appendModifiedParams call to pass array instead of object for API consistency
gcs/src/components/params/rowItem.jsx Updated styling classes and removed unnecessary className from Tooltip
gcs/src/components/params/paramsToolbar.jsx Removed functions moved to parent component, cleaned up unused imports, removed loadParamsFromFile parameter, reorganized layout structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread gcs/src/params.jsx Outdated

@1Blademaster 1Blademaster left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image This left hand side toolbar should be hidden while params are loading, or the buttons should be disabled. Image Can we center the search param text input and move the show modified params and reboot fc buttons to the toolbar on the left as well.

@bensgilbert

bensgilbert commented Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

@1Blademaster I've implemented that, in my opinion it looks worse, maybe we keep the reboot fc button in the sidebar but move "show all params" button back to the top and left align the search bar
I think that makes intuitive sense as the sidebar contains buttons that perform an action whereas the show all params button just filters the list to display to the user locally

@1Blademaster

Copy link
Copy Markdown
Member

@1Blademaster I've implemented that, in my opinion it looks worse, maybe we keep the reboot fc button in the sidebar but move "show all params" button back to the top and left align the search bar
I think that makes intuitive sense as the sidebar contains buttons that perform an action whereas the show all params button just filters the list to display to the user locally

Okay in that case leave the button next to the sidebar and put the reboot on the left, with a divider to section it off

@1Blademaster

Copy link
Copy Markdown
Member

Tested locally and works fine. Can we disable the show modified params button if no params have been modified?

repositioned `show modified params` button back to top toolbar
@bensgilbert bensgilbert merged commit 59e55af into main Nov 12, 2025
6 checks passed
@bensgilbert bensgilbert deleted the 769-fix-visual-styling-in-params-page branch November 12, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix visual styling in params page

3 participants