769 fix visual styling in params page#849
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the params page UI by introducing a resizable sidebar for parameter actions and reorganizing the toolbar. The main changes include moving write/refresh/save/load buttons from the horizontal toolbar into a new left sidebar, updating the API for adding modified params to accept arrays instead of objects, and streamlining the toolbar to focus on search and filtering functionality.
- Introduced a resizable sidebar using ResizableBox for parameter action buttons
- Moved param operations (refresh, write, save, load) from toolbar to sidebar
- Fixed appendModifiedParams to consistently accept arrays instead of objects
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gcs/src/params.jsx | Added resizable sidebar with action buttons, implemented refreshCallback and saveParamsToFile functions, restructured layout with new flex container hierarchy |
| gcs/src/components/params/valueInput.jsx | Fixed appendModifiedParams call to pass array instead of object for API consistency |
| gcs/src/components/params/rowItem.jsx | Updated styling classes and removed unnecessary className from Tooltip |
| gcs/src/components/params/paramsToolbar.jsx | Removed functions moved to parent component, cleaned up unused imports, removed loadParamsFromFile parameter, reorganized layout structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1Blademaster
left a comment
1Blademaster
left a comment
There was a problem hiding this comment.
This left hand side toolbar should be hidden while params are loading, or the buttons should be disabled.
Can we center the search param text input and move the show modified params and reboot fc buttons to the toolbar on the left as well.
center param search bar move controls to sidebar
|
@1Blademaster I've implemented that, in my opinion it looks worse, maybe we keep the reboot fc button in the sidebar but move "show all params" button back to the top and left align the search bar |
Okay in that case leave the button next to the sidebar and put the reboot on the left, with a divider to section it off |
|
Tested locally and works fine. Can we disable the show modified params button if no params have been modified? |
repositioned `show modified params` button back to top toolbar
No description provided.