856 recent logs list shows incorrect time#873
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #856 where the recent logs list displayed incorrect timestamps. The solution changes the data structure from storing an array of file path strings to storing an array of RecentLog objects that include both the file path and a timestamp captured when the log is opened.
Key Changes:
- Introduced
RecentLoginterface withpathandtimestampfields - Updated
recentLogManager.tsto store and retrieve timestamp data alongside file paths - Modified timestamp display in
main.tsto use stored timestamps instead of file modification time - Implemented backward compatibility migration for existing stored data
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
gcs/electron/types/flaTypes.ts |
Added RecentLog interface to define structure for recent log entries with path and timestamp |
gcs/electron/utils/recentLogManager.ts |
Refactored to work with RecentLog objects, storing timestamps when logs are opened, with migration logic for old string-based format |
gcs/electron/main.ts |
Updated IPC handler to use stored timestamps from RecentLog objects instead of file modification time |
gcs/electron/fla.ts |
Updated getRecentFiles() return type to match new RecentLog[] structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1Blademaster
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.