Skip to content

856 recent logs list shows incorrect time#873

Merged
Kwash67 merged 7 commits into
mainfrom
856-recent-logs-list-shows-incorrect-time
Nov 26, 2025
Merged

856 recent logs list shows incorrect time#873
Kwash67 merged 7 commits into
mainfrom
856-recent-logs-list-shows-incorrect-time

Conversation

@Kwash67

@Kwash67 Kwash67 commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@Kwash67 Kwash67 requested review from a team and Copilot November 25, 2025 16:25
@Kwash67 Kwash67 linked an issue Nov 25, 2025 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #856 where the recent logs list displayed incorrect timestamps. The solution changes the data structure from storing an array of file path strings to storing an array of RecentLog objects that include both the file path and a timestamp captured when the log is opened.

Key Changes:

  • Introduced RecentLog interface with path and timestamp fields
  • Updated recentLogManager.ts to store and retrieve timestamp data alongside file paths
  • Modified timestamp display in main.ts to use stored timestamps instead of file modification time
  • Implemented backward compatibility migration for existing stored data

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
gcs/electron/types/flaTypes.ts Added RecentLog interface to define structure for recent log entries with path and timestamp
gcs/electron/utils/recentLogManager.ts Refactored to work with RecentLog objects, storing timestamps when logs are opened, with migration logic for old string-based format
gcs/electron/main.ts Updated IPC handler to use stored timestamps from RecentLog objects instead of file modification time
gcs/electron/fla.ts Updated getRecentFiles() return type to match new RecentLog[] structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread gcs/electron/utils/recentLogManager.ts Outdated
Comment thread gcs/electron/utils/recentLogManager.ts Outdated
Comment thread gcs/electron/main.ts Outdated
Comment thread gcs/electron/types/flaTypes.ts
@Kwash67 Kwash67 merged commit 9a33ba6 into main Nov 26, 2025
5 checks passed
@Kwash67 Kwash67 deleted the 856-recent-logs-list-shows-incorrect-time branch November 26, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recent logs list shows incorrect time

3 participants