refactor: remove --no-delete-upload flag and auto-delete plumbing

Upload is a standalone action — auto-deleting the file the operator just
uploaded makes no sense. Removed:
- --no-delete-upload flag from all 12 commands
- NoDelete field from ExecutionUpload
- DeleteUploadedFile field and delete logic from FileStager
- CleanUpload method from ExecutionIO
- CleanUpload call from ExecuteCleanMethod

Co-authored-by: Carter <carter-falconops@users.noreply.github.com>

Author: cursoragent

cmd/args.go

@@ -52,7 +52,6 @@ func registerExecutionFlags(fs *pflag.FlagSet) {
 func registerExecutionUploadFlags(fs *pflag.FlagSet) {
 	fs.StringVar(&uploadSource, "upload", "", "Upload local `file` to remote filesystem")
 	fs.StringVar(&uploadDest, "upload-dest", "", "Remote destination `path` for uploaded file")
-	fs.BoolVar(&exec.Upload.NoDelete, "no-delete-upload", false, "Preserve uploaded file on remote filesystem")
 }
 
 func registerExecutionOutputFlags(fs *pflag.FlagSet) {

cmd/root.go

@@ -187,11 +187,10 @@ Authors: FalconOps LLC (@FalconOpsLLC),
 		if uploadSource != "" {
 			exec.Upload.RemotePath = uploadDest
 			exec.Upload.Provider = &smb.FileStager{
-				Client:             &smbClient,
-				Share:              `C$`,
-				SharePath:          `C:\`,
-				File:               uploadDest,
-				DeleteUploadedFile: !exec.Upload.NoDelete,
+				Client:    &smbClient,
+				Share:     `C$`,
+				SharePath: `C:\`,
+				File:      uploadDest,
 			}
 		}
 		return

pkg/goexec/io.go

@@ -35,7 +35,6 @@ type ExecutionOutput struct {
 }
 
 type ExecutionUpload struct {
-	NoDelete   bool
 	RemotePath string
 	Provider   InputProvider
 	Reader     io.ReadCloser
@@ -56,13 +55,6 @@ func (execIO *ExecutionIO) DoUpload(ctx context.Context) (err error) {
 	return nil
 }
 
-func (execIO *ExecutionIO) CleanUpload(ctx context.Context) (err error) {
-	if execIO.Upload != nil && execIO.Upload.Provider != nil {
-		return execIO.Upload.Provider.Clean(ctx)
-	}
-	return nil
-}
-
 func (execIO *ExecutionIO) GetOutput(ctx context.Context) (err error) {
   if execIO.Output.Provider != nil {
     ctx = context.WithValue(ctx, ContextOptionOutputTimeout, execIO.Output.Timeout)

pkg/goexec/method.go

@@ -141,13 +141,6 @@ func ExecuteCleanMethod(ctx context.Context, module CleanExecutionMethod, execIO
 		err = nil
 	}
 
-	// Upload cleanup (delete uploaded file if configured)
-	if execIO.Upload != nil && execIO.Upload.Provider != nil {
-		if cleanErr := execIO.CleanUpload(ctx); cleanErr != nil {
-			log.Debug().Err(cleanErr).Msg("Upload cleanup failed")
-		}
-	}
-
 	// Output collection
 	if execIO.Output != nil && execIO.Output.Provider != nil {
 		log.Info().Msg("Collecting output")

pkg/goexec/smb/input.go

@@ -16,12 +16,11 @@ type FileStager struct {
 
 	Client *Client
 
-	Share              string
-	SharePath          string
-	File               string
-	relativePath       string
-	ForceReconnect     bool
-	DeleteUploadedFile bool
+	Share          string
+	SharePath      string
+	File           string
+	relativePath   string
+	ForceReconnect bool
 }
 
 func (o *FileStager) Upload(ctx context.Context, reader io.Reader) (err error) {
@@ -60,11 +59,5 @@ func (o *FileStager) Upload(ctx context.Context, reader io.Reader) (err error) {
 
 	o.AddCleaners(func(_ context.Context) error { return writer.Close() })
 
-	if o.DeleteUploadedFile {
-		o.AddCleaners(func(_ context.Context) error {
-			return o.Client.mount.Remove(o.relativePath)
-		})
-	}
-
 	return
 }