Skip to content

Commit 015ad95

Browse files
gkorlandCopilot
andauthored
fix: address PR #455 review comments (#478)
- Pin uv version (0.7.12) and use --locked in CI workflows - Fix Dockerfile: split uv sync into deps-only + project install - Remove || true from make lint so pylint failures are not masked - Move max-line-length to [tool.pylint.format] (canonical section) - Fix docs: use 'uv sync' instead of 'uv add' for existing deps - Remove dead initial LLM_PROVIDER/AZURE_FLAG assignments in config Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 9a25ec0 commit 015ad95

7 files changed

Lines changed: 15 additions & 14 deletions

File tree

.github/workflows/playwright.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
- name: Install uv
3636
uses: astral-sh/setup-uv@d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 # v5.4.2
3737
with:
38-
version: "latest"
38+
version: "0.7.12"
3939

4040
# Setup Node.js
4141
- uses: actions/setup-node@v6
@@ -49,7 +49,7 @@ jobs:
4949
5050
# Install Python dependencies
5151
- name: Install Python dependencies
52-
run: uv sync
52+
run: uv sync --locked
5353

5454
# Install Node dependencies (root - for Playwright)
5555
- name: Install root dependencies

.github/workflows/tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@ jobs:
3939
- name: Install uv
4040
uses: astral-sh/setup-uv@d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 # v5.4.2
4141
with:
42-
version: "latest"
42+
version: "0.7.12"
4343

4444
- name: Install dependencies
4545
run: |
46-
uv sync
46+
uv sync --locked
4747
4848
- name: Install frontend dependencies
4949
run: |

Dockerfile

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ ENV UV_SYSTEM_PYTHON=1
4040
# Ensure venv binaries are on PATH (uv sync always creates .venv)
4141
ENV PATH="/app/.venv/bin:$PATH"
4242

43-
# Install Python dependencies from pyproject.toml
44-
RUN uv sync --frozen --no-dev
43+
# Install Python dependencies only (project itself installed after COPY)
44+
RUN uv sync --frozen --no-dev --no-install-project
4545

4646
# Install Node.js (Node 22) so we can build the frontend inside the image.
4747
# Use NodeSource setup script to get a recent Node version on Debian-based images.
@@ -75,6 +75,9 @@ RUN npm --prefix ./app run build
7575
# Copy application code
7676
COPY . .
7777

78+
# Install the project package now that source code is available
79+
RUN uv sync --frozen --no-dev
80+
7881
# Copy and make start.sh executable
7982
COPY start.sh /start.sh
8083
RUN chmod +x /start.sh

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ test-e2e-debug: build-dev ## Run E2E tests with debugging enabled
4242

4343
lint: ## Run linting (backend + frontend)
4444
@echo "Running backend lint (pylint)"
45-
uv run python -m pylint $(shell git ls-files '*.py') || true
45+
uv run python -m pylint $(shell git ls-files '*.py')
4646
@echo "Running frontend lint (eslint)"
4747
make lint-frontend
4848

api/config.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,6 @@ class Config:
7070
Configuration class for the text2sql module.
7171
"""
7272

73-
# Provider flag: "azure", "openai", "gemini", "anthropic", "ollama", "cohere"
74-
LLM_PROVIDER = "azure"
75-
AZURE_FLAG = True
76-
7773
# User-provided overrides via env vars
7874
_user_completion = os.getenv("COMPLETION_MODEL", "")
7975
_user_embedding = os.getenv("EMBEDDING_MODEL", "")

docs/postgres_loader.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ This loader connects to a PostgreSQL database and extracts the complete schema i
1313

1414
## Installation
1515

16-
psycopg2-binary is already included in QueryWeaver's dependencies. If you need to add it manually:
16+
psycopg2-binary is already included in QueryWeaver's dependencies. Install project dependencies with:
1717

1818
```bash
19-
uv add psycopg2-binary
19+
uv sync
2020
```
2121

2222
## Usage

pyproject.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,11 @@ filterwarnings = [
6262
]
6363

6464
[tool.pylint.main]
65-
max-line-length = 120
6665
disable = [
6766
"C0114", # missing-module-docstring
6867
"C0115", # missing-class-docstring
6968
"C0116", # missing-function-docstring
7069
]
70+
71+
[tool.pylint.format]
72+
max-line-length = 120

0 commit comments

Comments
 (0)