fix(usage): correct success semantics, env-agnostic test, doc wording

Address the latest review pass:
- routes/graphs: success = is_valid AND no error. error_message-None alone
  counted off-topic / not-SQL-translatable results (is_valid=False, no error)
  as successes, inflating success_count.
- tests: assert against usage_tracking.ORGANIZATIONS_GRAPH instead of the
  hardcoded "Organizations" so the suite passes when the env var is set.
- usage_tracking: reword the task_sink docstring — it no longer ships in the
  SDK, so drop the QueryWeaver.close() reference for a generic description.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: galshubeli

api/routes/graphs.py

@@ -55,8 +55,12 @@ async def _serialize_pipeline(gen, *, user_id, namespaced):
             break
         yield json.dumps(event) + MESSAGE_DELIMITER
     if final is not None and not final.requires_confirmation:
+        # "Success" = a valid query that ran without error. error_message is
+        # None alone isn't enough: off-topic / not-SQL-translatable results
+        # carry is_valid=False with no error, and must not inflate success_count.
         record_query_usage_background(
-            user_id, namespaced, success=final.error_message is None
+            user_id, namespaced,
+            success=final.is_valid and final.error_message is None,
         )
 
 

api/routes/usage_tracking.py

@@ -120,7 +120,8 @@ def record_query_usage_background(
         success: Whether SQL execution succeeded (no execution error).
         db: Optional FalkorDB handle; resolves to the server singleton when None.
         task_sink: Optional set the scheduled task is added to (and auto-removed
-            from on completion) so SDK ``QueryWeaver.close()`` can await it.
+            from on completion) so callers can await any in-flight tracking
+            writes before shutdown.
     """
     email = _decode_email(user_id)
     if email is None:

tests/test_usage_tracking.py

@@ -68,7 +68,7 @@ async def test_records_successful_query_event(self):
             )
             await _drain(sink)
 
-        db.select_graph.assert_called_once_with("Organizations")
+        db.select_graph.assert_called_once_with(usage_tracking.ORGANIZATIONS_GRAPH)
         graph.query.assert_awaited_once()
         cypher, params = graph.query.await_args.args
         assert "MATCH (u:User {email: $email})" in cypher