chore(deps): bump react-dom and @types/react-dom in /app#489
Open
dependabot[bot] wants to merge 2 commits intostagingfrom
Open
chore(deps): bump react-dom and @types/react-dom in /app#489dependabot[bot] wants to merge 2 commits intostagingfrom
dependabot[bot] wants to merge 2 commits intostagingfrom
Conversation
dependabot
bot
added
dependencies
Completed Working on "Code Review"✅ Workflow completed successfully. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files
|
![overcut-ai[bot]](https://avatars.githubusercontent.com/in/1367736?s=60&v=4){kind=small}
There was a problem hiding this comment.
Final Review Summary
Findings by importance
- 2 BLOCKER
- 1 MAJOR
- 0 CRITICAL, 0 MINOR, 0 SUGGESTION, 0 PRAISE
Total: 3 comments across 2 files.
Key themes
- React runtime version alignment issue:
react-domwas upgraded to 19.x whilereactremains on 18.x, creating an unsupported peer dependency pairing. - Type ecosystem mismatch:
@types/react-dom19.x is incompatible with@types/react18.x, risking TypeScript/lint failures. - Lockfile reproducibility risk: lockfile now encodes incompatible peer requirements, which can break clean installs in stricter environments.
Recommended next steps
- Upgrade
reactand@types/reactto compatible 19.x versions in the same PR and regenerate the lockfile. - If a React 19 migration is not intended yet, revert
react-domand@types/react-domto 18.x. - Re-run dependency install and CI checks after version alignment to confirm peer dependency consistency.
| "react": "^18.3.1", | ||
| "react-day-picker": "^8.10.1", | ||
| "react-dom": "^18.3.1", | ||
| "react-dom": "^19.2.4", |
There was a problem hiding this comment.
[blocker]: This change upgrades react-dom to 19.2.4 while keeping react at 18.3.1, violating react-dom’s peer requirement and creating an unsupported runtime pairing that can fail installs under strict peer resolution and cause runtime incompatibilities.
Upgrade react to a matching 19.x version in the same PR (and validate app behavior), or keep react-dom on 18.x until a coordinated migration is done.
| "license": "MIT", | ||
| "peerDependencies": { | ||
| "@types/react": "^18.0.0" | ||
| "@types/react": "^19.2.0" |
There was a problem hiding this comment.
[blocker]: The lockfile resolves @types/react-dom@19.2.3, which peers on @types/react ^19.2.0, while the project remains on @types/react ^18.3.23. This creates an incompatible type graph that can break TypeScript/lint in CI and editor tooling.
Upgrade @types/react to a compatible 19.x version alongside @types/react-dom, or pin @types/react-dom back to 18.x until the React 19 migration is complete.
| }, | ||
| "peerDependencies": { | ||
| "react": "^18.3.1" | ||
| "react": "^19.2.4" |
There was a problem hiding this comment.
[major]: The lockfile now records react-dom@19.2.4 requiring react@^19.2.4 while the app remains on react@^18.3.1. This inconsistent graph can fail clean installs under peer enforcement and reduce reproducibility across environments.
Regenerate the lockfile only after aligning react and react-dom to compatible versions (same major/minor line) so peer dependencies are satisfied.
gkorland
added a commit
that referenced
this pull request
Mar 27, 2026
Python dependencies: - uvicorn: 0.41.0 → 0.42.0 - litellm: 1.82.0 → 1.82.6 - authlib: 1.6.8 → 1.6.9 - fastmcp: 3.0.1 → 3.1.1 - pytest-asyncio: 1.2.0 → 1.3.0 GitHub Actions: - astral-sh/setup-uv: v5.4.2 → v7.6.0 - rojopolis/spellcheck-github-actions: 0.59.0 → 0.60.0 NPM dependencies (app/): - typescript-eslint: 8.53.0 → 8.57.0 - flatted: 3.3.3 → 3.4.2 - picomatch: 2.3.1 → 2.3.2 / 4.0.3 → 4.0.4 Replaces: #483, #484, #486, #487, #491, #493, #498, #499, #500, #501 Skipped major version bumps (require migration work): - #488 vite 7→8, #489 react-dom 18→19 - #490 tailwind-merge 2→3, #492 tailwindcss 3→4 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
gkorland
added a commit
that referenced
this pull request
Mar 27, 2026
Python dependencies: - uvicorn: 0.41.0 → 0.42.0 - litellm: 1.82.0 → 1.82.6 - authlib: 1.6.8 → 1.6.9 - fastmcp: 3.0.1 → 3.1.1 - pytest-asyncio: 1.2.0 → 1.3.0 GitHub Actions: - astral-sh/setup-uv: v5.4.2 → v7.6.0 - rojopolis/spellcheck-github-actions: 0.59.0 → 0.60.0 NPM dependencies (app/): - typescript-eslint: 8.53.0 → 8.57.0 - flatted: 3.3.3 → 3.4.2 - picomatch: 2.3.1 → 2.3.2 / 4.0.3 → 4.0.4 Replaces: #483, #484, #486, #487, #491, #493, #498, #499, #500, #501 Skipped major version bumps (require migration work): - #488 vite 7→8, #489 react-dom 18→19 - #490 tailwind-merge 2→3, #492 tailwindcss 3→4 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Bumps [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom) and [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom). These dependencies needed to be updated together. Updates `react-dom` from 18.3.1 to 19.2.4 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.4/packages/react-dom) Updates `@types/react-dom` from 18.3.7 to 19.2.3 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: react-dom dependency-version: 19.2.4 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/react-dom" dependency-version: 19.2.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/app/staging/multi-c6586c7467
branch
from
2ddb114 to
71ae9d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps react-dom and @types/react-dom. These dependencies needed to be updated together.
Updates
react-domfrom 18.3.1 to 19.2.4Release notes
Sourced from react-dom's releases.
... (truncated)
Changelog
Sourced from react-dom's changelog.
... (truncated)
Commits
90ab3f8Version 19.2.4612e371Version 19.2.3b910fc1Version 19.2.2053df4eVersion 19.2.18618113Bump scheduler version (#34671)1bd1f01Ship partial-prerendering APIs to Canary (#34633)2f0649a[Fizz] Removenonceoption from resume-and-prerender APIs (#34664)5667a41Bump next prerelease version numbers (#34639)e08f53bMatchreact-dom/statictest entrypoints and published entrypoints (#34599)8bb7241Bump useEffectEvent to Canary (#34610)Updates
@types/react-domfrom 18.3.7 to 19.2.3Commits