fix(javascript): skip NullLanguageServer in second pass, add integration test

- Skip symbol resolution for files whose LSP is NullLanguageServer, avoiding
  unnecessary exception handling during second-pass (addresses coderabbit
  review on source_analyzer.py)
- Add SourceAnalyzer.create_hierarchy integration test with MockGraph to
  verify the production code path for JS entity extraction and edge creation
  without requiring a database connection (addresses coderabbit review on
  test coverage)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: gkorland

api/analyzers/source_analyzer.py

@@ -151,6 +151,9 @@ def second_pass(self, graph: Graph, files: list[Path], path: Path) -> None:
             for i, file_path in enumerate(files):
                 file = self.files[file_path]
                 logging.info(f'Processing file ({i + 1}/{files_len}): {file_path}')
+                # Skip symbol resolution when no real LSP is available
+                if isinstance(lsps.get(file_path.suffix), NullLanguageServer):
+                    continue
                 for _, entity in file.entities.items():
                     entity.resolved_symbol(lambda key, symbol, fp=file_path: analyzers[fp.suffix].resolve_symbol(self.files, lsps[fp.suffix], fp, path, key, symbol))
                     for key, symbols in entity.symbols.items():

tests/test_javascript_analyzer.py

@@ -221,6 +221,50 @@ def test_source_analyzer_supported_types_includes_js(self):
         sa = SourceAnalyzer()
         self.assertIn(".js", sa.supported_types())
 
+    def test_source_analyzer_create_hierarchy(self):
+        """SourceAnalyzer.create_hierarchy() should process JS files correctly.
+
+        Uses a lightweight mock Graph to verify the production code path
+        without requiring a database connection.
+        """
+        class MockGraph:
+            def __init__(self):
+                self._next_id = 1
+                self.entities = {}
+                self.edges = []
+
+            def add_file(self, file):
+                file.id = self._next_id
+                self._next_id += 1
+
+            def add_entity(self, label, name, doc, path, src_start, src_end, props):
+                eid = self._next_id
+                self._next_id += 1
+                self.entities[eid] = {"label": label, "name": name, "doc": doc}
+                return eid
+
+            def connect_entities(self, rel, src, dest, props=None):
+                self.edges.append((rel, src, dest))
+
+        sa = SourceAnalyzer()
+        source = self.sample_path.read_bytes()
+        tree = self.analyzer.parser.parse(source)
+        file = File(self.sample_path, tree)
+        graph = MockGraph()
+        graph.add_file(file)
+        sa.create_hierarchy(file, self.analyzer, graph)
+
+        entity_names = [e["name"] for e in graph.entities.values()]
+        self.assertIn("Shape", entity_names)
+        self.assertIn("Circle", entity_names)
+        self.assertIn("calculateTotal", entity_names)
+        self.assertIn("area", entity_names)
+        self.assertIn("constructor", entity_names)
+
+        # Verify DEFINES edges were created (file → entities)
+        defines_edges = [e for e in graph.edges if e[0] == "DEFINES"]
+        self.assertTrue(len(defines_edges) > 0, "Should create DEFINES edges")
+
 
 if __name__ == "__main__":
     unittest.main()