Commit dafc549
fix(combobox): add error handling and fix placeholder selection
- Add catch block for network errors with toast notification
- Disable Select during loading and when no options available
- Use placeholder prop instead of selectable placeholder items
- Move lastFetch timestamp update to after successful fetch
Addresses CodeRabbit review comments on combobox.tsx.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 78780de commit dafc549
1 file changed
Lines changed: 10 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
46 | 53 | | |
47 | 54 | | |
48 | 55 | | |
| |||
60 | 67 | | |
61 | 68 | | |
62 | 69 | | |
63 | | - | |
64 | | - | |
65 | | - | |
| 70 | + | |
66 | 71 | | |
67 | 72 | | |
68 | 73 | | |
69 | 74 | | |
70 | | - | |
| 75 | + | |
71 | 76 | | |
72 | | - | |
| 77 | + | |
73 | 78 | | |
74 | 79 | | |
75 | 80 | | |
| |||
0 commit comments