Skip to content

Fix MSBuild tool resolve for VS2026#420

Merged
ChrisonSimtian merged 2 commits into
Fallout-build:mainfrom
ITaluone:fix/vs2026-msbuild-resolve
Jun 25, 2026
Merged

Fix MSBuild tool resolve for VS2026#420
ChrisonSimtian merged 2 commits into
Fallout-build:mainfrom
ITaluone:fix/vs2026-msbuild-resolve

Conversation

@ITaluone

@ITaluone ITaluone commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

This originates from: nuke-build/nuke#1583

Thanks @Kielek

@ITaluone
ITaluone requested a review from a team as a code owner June 24, 2026 12:32

@Kielek Kielek left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great to see the fix propagated here.
If nothing change, I will need to switch https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation to new tool.

@ChrisonSimtian ChrisonSimtian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ChrisonSimtian ChrisonSimtian added the Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved label Jun 24, 2026
@ChrisonSimtian
ChrisonSimtian force-pushed the fix/vs2026-msbuild-resolve branch from 5182de0 to e55ae28 Compare June 25, 2026 00:26
@ChrisonSimtian
ChrisonSimtian merged commit da2b718 into Fallout-build:main Jun 25, 2026
1 check passed
@ITaluone
ITaluone deleted the fix/vs2026-msbuild-resolve branch June 25, 2026 05:06
@ChrisonSimtian ChrisonSimtian added the bug Something isn't working label Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants