some more clean-up

Author: gykovacs

mlscorecheck/aggregated/_evaluation.py

@@ -72,7 +72,7 @@ def to_dict(self) -> dict:
 
     def sample_figures(
         self, 
-        random_state=None, 
+        random_state: int | None = None, 
         score_subset: list | None = None
     ) -> "Evaluation":
         """

mlscorecheck/aggregated/_experiment.py

@@ -63,7 +63,7 @@ def to_dict(self) -> dict:
 
     def sample_figures(
         self, 
-        random_state=None, 
+        random_state: int | None = None, 
         score_subset: list | None = None
     ) -> "Experiment":
         """
@@ -166,7 +166,7 @@ def init_lp(self, lp_problem: pl.LpProblem, scores: dict | None = None) -> pl.Lp
 
         return lp_problem
 
-    def populate(self, lp_problem) -> "Experiment":
+    def populate(self, lp_problem: pl.LpProblem) -> "Experiment":
         """
         Populates the evaluation with the figures in the solved linear programming problem
 

mlscorecheck/aggregated/_fold.py

@@ -54,7 +54,7 @@ def to_dict(self) -> dict:
         """
         return {"p": self.p, "n": self.n, "identifier": self.identifier}
 
-    def sample_figures(self, random_state=None) -> "Fold":
+    def sample_figures(self, random_state: int | None = None) -> "Fold":
         """
         Samples the ``tp`` and ``tn`` figures
 

mlscorecheck/aggregated/_generate_problems.py

@@ -31,7 +31,7 @@ def generate_dataset(
     max_p: int = 100,
     max_n: int = 100,
     *,
-    random_state=None,
+    random_state: int | None = None,
 ) -> dict:
     """
     Generate a random dataset specification

mlscorecheck/check/bundles/retina/_diaretdb1.py

@@ -22,7 +22,7 @@
 ]
 
 
-def _prepare_testsets_diaretdb1(subset_indices, data, key, assumption, threshold):
+def _prepare_testsets_diaretdb1(subset_indices: list, data: dict, key: str, assumption: str, threshold: float) -> tuple[list, dict]:
     """
     Helper function for generating the diaretdb1 evaluation configuration
 
@@ -60,7 +60,7 @@ def _prepare_testsets_diaretdb1(subset_indices, data, key, assumption, threshold
 
 
 def _prepare_configuration_diaretdb1(
-    *, subset, class_name, pixel_level: bool, assumption: str, confidence: float, only_valid=False
+    *, subset: str | list, class_name: str | list, pixel_level: bool, assumption: str, confidence: float, only_valid: bool = False
 ) -> list:
     """
     Prepares the experiment confuguration based on the description

mlscorecheck/check/bundles/retina/_hrf.py

@@ -117,7 +117,7 @@ def check_hrf_vessel_aggregated_mos_assumption(
 
 
 def check_hrf_vessel_aggregated_som_assumption(
-    imageset, assumption: str, scores: dict, eps, numerical_tolerance=NUMERICAL_TOLERANCE
+    imageset: str | list, assumption: str, scores: dict, eps: float | dict, numerical_tolerance: float = NUMERICAL_TOLERANCE
 ) -> dict:
     """
     Tests the consistency of scores calculated on the HRF dataset using

mlscorecheck/individual/_utils.py

@@ -37,7 +37,7 @@
 functions_standardized = score_functions_standardized_without_complements
 
 
-def translate_metadata(original) -> dict | list:
+def translate_metadata(original: dict | list) -> dict | list:
     """
     Translates the metadata, internally uses p instead of n_positive, n_minority or
     n_1, and similarly, internally uses n instead of n_negative, n_majority, or n_0.

mlscorecheck/scores/_calculate_scores.py

@@ -101,7 +101,7 @@ def calculate_scores(
 
 def calculate_multiclass_scores(
     confusion_matrix: np.ndarray,
-    average=None,
+    average: str | None = None,
     *,
     rounding_decimals: int | None = None,
     additional_symbols: dict | None = None,