ruff fixes

Author: gykovacs

.flake8

@@ -1,2 +1,25 @@
 [flake8]
 max-line-length = 100
+ignore = 
+    # Allow star imports in __init__.py files
+    F403,
+    F405,
+    # Allow unused imports in __init__.py files (they're for public API)
+    F401,
+    # Scientific naming conventions
+    N803,
+    N806,
+exclude = 
+    .git,
+    __pycache__,
+    build,
+    dist,
+    .eggs,
+    docs/_build,
+per-file-ignores =
+    __init__.py:F401,F403,F405
+    # Allow long lines in mathematical formula files
+    */individual/_tptn_solutions.py:E501
+    # Allow long lines in docstring score lists  
+    */check/bundles/*:E501
+    */check/multiclass/*:E501

.github/workflows/build.yml

@@ -26,14 +26,18 @@ jobs:
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install flake8
+          pip install flake8 ruff pylint mypy
 
       - name: Lint with flake8
         run: |
           # stop the build if there are Python syntax errors or undefined names
           flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
           # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
-          flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+          flake8 . --count --exit-zero --max-complexity=10 --max-line-length=100 --statistics
+
+      - name: Lint with ruff
+        run: |
+          ruff check --output-format=github .
 
   test:
     name: Test Python ${{ matrix.python-version }} on ${{ matrix.os }}

mlscorecheck/__init__.py

@@ -2,10 +2,5 @@
 This module brings together all functionalities.
 """
 
-from . import check
-from . import core
-from . import experiments
-from . import symbolic
-from . import individual
-from . import aggregated
+from . import aggregated, check, core, experiments, individual, symbolic
 from ._version import *

mlscorecheck/aggregated/__init__.py

@@ -2,14 +2,14 @@
 This module brings together all the logic related to aggregated figures
 """
 
-from ._folding import *
-from ._fold import *
-from ._fold_enumeration import *
+from ._check_aggregated_scores import *
 from ._dataset import *
 from ._evaluation import *
 from ._experiment import *
+from ._fold import *
+from ._fold_enumeration import *
+from ._folding import *
+from ._folding_utils import *
+from ._generate_problems import *
 from ._linear_programming import *
 from ._utils import *
-from ._check_aggregated_scores import *
-from ._generate_problems import *
-from ._folding_utils import *

mlscorecheck/aggregated/_check_aggregated_scores.py

@@ -6,16 +6,15 @@
 import pulp as pl
 
 from ..core import (
-    logger,
     NUMERICAL_TOLERANCE,
     check_uncertainty_and_tolerance,
+    logger,
     update_uncertainty,
 )
 from ..individual import resolve_aliases_and_complements
-
 from ._experiment import Experiment
 from ._linear_programming import solve
-from ._utils import compare_scores, aggregated_scores
+from ._utils import aggregated_scores, compare_scores
 
 __all__ = ["check_aggregated_scores"]
 

mlscorecheck/aggregated/_dataset.py

@@ -4,9 +4,8 @@
 # disabling pylint false positives
 # pylint: disable=no-member
 
-from ._utils import random_identifier
-
 from ..experiments import dataset_statistics
+from ._utils import random_identifier
 
 __all__ = ["Dataset"]
 

mlscorecheck/aggregated/_evaluation.py

@@ -4,12 +4,12 @@
 
 import pulp as pl
 
+from ..core import NUMERICAL_TOLERANCE, dict_mean, init_random_state, round_scores
+from ..scores import calculate_scores_for_lp
 from ._dataset import Dataset
 from ._folding import Folding
-from ..core import init_random_state, dict_mean, round_scores, NUMERICAL_TOLERANCE
-from ..scores import calculate_scores_for_lp
-from ._utils import check_bounds, aggregated_scores
 from ._linear_programming import add_bounds
+from ._utils import aggregated_scores, check_bounds
 
 
 class Evaluation:

mlscorecheck/aggregated/_experiment.py

@@ -4,13 +4,11 @@
 
 import pulp as pl
 
-from ..core import init_random_state, dict_mean, round_scores, NUMERICAL_TOLERANCE
+from ..core import NUMERICAL_TOLERANCE, dict_mean, init_random_state, round_scores
 from ..scores import calculate_scores_for_lp
-
 from ._evaluation import Evaluation
-
-from ._utils import check_bounds, aggregated_scores
 from ._linear_programming import add_bounds
+from ._utils import aggregated_scores, check_bounds
 
 __all__ = ["Experiment"]
 

mlscorecheck/aggregated/_fold.py

@@ -11,8 +11,7 @@
 
 from ..core import init_random_state, round_scores
 from ..scores import calculate_scores_for_lp
-
-from ._utils import random_identifier, aggregated_scores
+from ._utils import aggregated_scores, random_identifier
 
 __all__ = ["Fold"]
 

mlscorecheck/aggregated/_fold_enumeration.py

@@ -302,7 +302,7 @@ def kfolds_generator(evaluation: dict, available_scores: list, repeat_idx=0):
                 "n": n_,
                 "identifier": f"{evaluation['dataset']['identifier']}_f{idx}_k{jdx}_r{repeat_idx}",
             }
-            for idx, (p_, n_) in enumerate(zip(p_vals, n_vals))
+            for idx, (p_, n_) in enumerate(zip(p_vals, n_vals, strict=False))
         ]