-
Notifications
You must be signed in to change notification settings - Fork 4
Add Tag Extension structures #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
glamberson
wants to merge
11
commits into
FamilySearch:main
Choose a base branch
from
glamberson:add-tag-extension
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e407eb3
Add Tag Extension structures
lamco-office 26707a7
Fix YAML validation errors for TAG extension
lamco-office 4e7fb1b
Add newline
tychonievich 668f849
Add newline
tychonievich 0ea2f85
Add newline
tychonievich c8d25f2
Add newline
tychonievich 5eb8e3d
Add newline
tychonievich 9d69d7f
Add newline
tychonievich d219b90
Fix issues identified in PR review
lamco-office f94bc01
Fix PR #174 review issues
lamco-office 90f23cd
Remove helper script and reset submodule to upstream
lamco-office File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule GEDCOM.io
updated
3 files
| +10 −10 | Gemfile.lock | |
| + − | specifications/FamilySearchGEDCOMv7.pdf | |
| +4 −0 | yaml-schema.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| %YAML 1.2 | ||
| --- | ||
| lang: en-US | ||
|
|
||
| type: structure | ||
|
|
||
| uri: https://github.com/glamberson/gedcom-tags/_ATTR | ||
|
|
||
| extension tags: | ||
| - _ATTR | ||
|
|
||
| specification: | ||
| - Generic Attribute | ||
| - | | ||
| The _ATTR structure provides a generic mechanism for vendors to add | ||
| custom attributes to tags. The payload contains the attribute name, | ||
| and the required _VALUE substructure contains the attribute value. | ||
|
|
||
| This allows software to extend tags with specific functionality | ||
| without requiring changes to the base specification. | ||
|
|
||
| label: 'Attribute' | ||
|
|
||
| payload: http://www.w3.org/2001/XMLSchema#string | ||
|
|
||
| substructures: | ||
| "https://github.com/glamberson/gedcom-tags/_VALUE": "{1:1}" | ||
|
|
||
| superstructures: | ||
| "https://github.com/glamberson/gedcom-tags/_TAG": "{0:M}" | ||
|
|
||
| contact: "lamberson@yahoo.com" | ||
|
|
||
| ... | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| %YAML 1.2 | ||
| --- | ||
| lang: en-US | ||
|
|
||
| type: structure | ||
|
|
||
| uri: https://github.com/glamberson/gedcom-tags/_COLOR | ||
|
|
||
| extension tags: | ||
| - _COLOR | ||
|
|
||
| specification: | ||
| - Color | ||
| - | | ||
| The _COLOR structure specifies a color for visual representation of a tag. | ||
| The color must be specified as a 6-digit hexadecimal value in the format | ||
| #RRGGBB, where RR is red, GG is green, and BB is blue. Values are | ||
| case-insensitive. | ||
|
|
||
| Examples: #FF0000 (red), #00FF00 (green), #0000FF (blue) | ||
|
|
||
| label: 'Color' | ||
|
|
||
| payload: http://www.w3.org/2001/XMLSchema#string | ||
|
|
||
| substructures: {} | ||
|
|
||
| superstructures: | ||
| "https://github.com/glamberson/gedcom-tags/_TAG": "{0:1}" | ||
|
|
||
| contact: "lamberson@yahoo.com" | ||
|
|
||
| ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,39 @@ | ||||||
| %YAML 1.2 | ||||||
| --- | ||||||
| lang: en-US | ||||||
|
|
||||||
| type: record | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| uri: https://github.com/glamberson/gedcom-tags/_TAG | ||||||
|
|
||||||
| extension tags: | ||||||
| - _TAG | ||||||
|
|
||||||
| specification: | ||||||
| - Tag Record | ||||||
| - | | ||||||
| A _TAG record represents an organizational tag that can be applied to | ||||||
| any record type for categorization purposes. Tags support optional | ||||||
| visual color coding and vendor-specific attributes through the | ||||||
| generic _ATTR mechanism. | ||||||
|
|
||||||
| Tags are first-class records that exist at the top level and are | ||||||
| referenced by other records using the _TAG substructure. | ||||||
|
|
||||||
| label: 'Tag' | ||||||
|
|
||||||
| payload: null | ||||||
|
|
||||||
| substructures: | ||||||
| "https://gedcom.io/terms/v7/NAME": "{1:1}" | ||||||
| "https://github.com/glamberson/gedcom-tags/_COLOR": "{0:1}" | ||||||
| "https://github.com/glamberson/gedcom-tags/_ATTR": "{0:M}" | ||||||
| "https://gedcom.io/terms/v7/NOTE": "{0:M}" | ||||||
| "https://gedcom.io/terms/v7/SNOTE": "{0:M}" | ||||||
| "https://gedcom.io/terms/v7/CHAN": "{0:1}" | ||||||
|
|
||||||
| superstructures: {} | ||||||
|
|
||||||
| contact: "lamberson@yahoo.com" | ||||||
|
|
||||||
| ... | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| %YAML 1.2 | ||
| --- | ||
| lang: en-US | ||
|
|
||
| type: structure | ||
|
|
||
| uri: https://github.com/glamberson/gedcom-tags/_TAG_ref | ||
|
|
||
| extension tags: | ||
| - _TAG | ||
|
|
||
| specification: | ||
| - Tag Reference | ||
| - | | ||
| When used as a substructure, _TAG references a tag record to apply | ||
| that tag to the containing record. The payload is a pointer to a | ||
| _TAG record. Optional DATE and NOTE substructures can provide | ||
| context about when and why the tag was applied. | ||
|
|
||
| label: 'Tag Reference' | ||
|
|
||
| payload: "@<https://github.com/glamberson/gedcom-tags/_TAG>@" | ||
|
|
||
| substructures: | ||
| "https://gedcom.io/terms/v7/DATE": "{0:1}" | ||
| "https://gedcom.io/terms/v7/NOTE": "{0:M}" | ||
|
|
||
| superstructures: | ||
| "https://gedcom.io/terms/v7/record-INDI": "{0:M}" | ||
| "https://gedcom.io/terms/v7/record-FAM": "{0:M}" | ||
| "https://gedcom.io/terms/v7/record-SOUR": "{0:M}" | ||
| "https://gedcom.io/terms/v7/record-REPO": "{0:M}" | ||
| "https://gedcom.io/terms/v7/record-OBJE": "{0:M}" | ||
| "https://gedcom.io/terms/v7/record-NOTE": "{0:M}" | ||
| "https://gedcom.io/terms/v7/record-SNOTE": "{0:M}" | ||
| "https://gedcom.io/terms/v7/record-SUBM": "{0:M}" | ||
| "https://gedcom.io/terms/v7/EVEN": "{0:M}" | ||
| "https://gedcom.io/terms/v7/BIRT": "{0:M}" | ||
| "https://gedcom.io/terms/v7/DEAT": "{0:M}" | ||
| "https://gedcom.io/terms/v7/MARR": "{0:M}" | ||
| "https://gedcom.io/terms/v7/CENS": "{0:M}" | ||
| "https://gedcom.io/terms/v7/PLAC": "{0:M}" | ||
| "https://gedcom.io/terms/v7/NAME": "{0:M}" | ||
| "https://gedcom.io/terms/v7/ASSO": "{0:M}" | ||
|
|
||
| contact: "lamberson@yahoo.com" | ||
|
|
||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if this is in use by gramps as you said:
Then add |
||
| ... | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| %YAML 1.2 | ||
| --- | ||
| lang: en-US | ||
|
|
||
| type: structure | ||
|
|
||
| uri: https://github.com/glamberson/gedcom-tags/_VALUE | ||
|
|
||
| extension tags: | ||
| - _VALUE | ||
|
|
||
| specification: | ||
| - Attribute Value | ||
| - | | ||
| The _VALUE structure contains the value for a generic attribute | ||
| defined by _ATTR. The value is a string that can contain any | ||
| vendor-specific data. | ||
|
|
||
| label: 'Value' | ||
|
|
||
| payload: http://www.w3.org/2001/XMLSchema#string | ||
|
|
||
| substructures: {} | ||
|
|
||
| superstructures: | ||
| "https://github.com/glamberson/gedcom-tags/_ATTR": "{1:1}" | ||
|
|
||
| contact: "lamberson@yahoo.com" | ||
|
|
||
| ... |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend adding
To YAML files in this PR.