making sure tests are up to date

Author: neil-pack

.phpunit.result.cache

@@ -0,0 +1 @@
+{"version":1,"defects":{"Gedcomx\\Unit\\GedcomxFileTests::testCreateGedxFile":5},"times":{"Gedcomx\\Tests\\Unit\\Agent\\AddressTests::testAddressDeserialization":0.012,"Gedcomx\\Tests\\Unit\\Agent\\AddressTests::testAddressGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Agent\\AddressTests::testAddressWithMinimalData":0,"Gedcomx\\Tests\\Unit\\Agent\\AgentTests::testAgentDeserialization":0.002,"Gedcomx\\Tests\\Unit\\Agent\\AgentTests::testAgentGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Agent\\AgentTests::testAgentWithoutNames":0,"Gedcomx\\Tests\\Unit\\Conclusion\\DocumentTests::testDocumentDeserialization":0.001,"Gedcomx\\Tests\\Unit\\Conclusion\\DocumentTests::testDocumentGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Conclusion\\DocumentTests::testDocumentWithoutText":0,"Gedcomx\\Tests\\Unit\\Conclusion\\EventTests::testEventDeserialization":0.001,"Gedcomx\\Tests\\Unit\\Conclusion\\EventTests::testEventGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Conclusion\\EventTests::testEventWithoutRoles":0,"Gedcomx\\Tests\\Unit\\Conclusion\\FactTests::testFactDeserialization":0,"Gedcomx\\Tests\\Unit\\Conclusion\\FactTests::testFactGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Conclusion\\FactTests::testFactWithoutDate":0,"Gedcomx\\Tests\\Unit\\Conclusion\\GenderTests::testGenderDeserialization":0,"Gedcomx\\Tests\\Unit\\Conclusion\\GenderTests::testGenderGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Conclusion\\GenderTests::testGenderWithNullType":0,"Gedcomx\\Tests\\Unit\\Conclusion\\NameTests::testNameDeserialization":0,"Gedcomx\\Tests\\Unit\\Conclusion\\NameTests::testNameGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Conclusion\\NameTests::testNameWithMultipleForms":0,"Gedcomx\\Tests\\Unit\\Conclusion\\PersonTests::testPerson":0.002,"Gedcomx\\Tests\\Unit\\Conclusion\\PlaceDescriptionTests::testPlaceDescriptionDeserialization":0,"Gedcomx\\Tests\\Unit\\Conclusion\\PlaceDescriptionTests::testPlaceDescriptionGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Conclusion\\PlaceDescriptionTests::testPlaceDescriptionWithoutCoordinates":0,"Gedcomx\\Tests\\Unit\\Conclusion\\RelationshipTests::testRelationshipDeserialization":0.001,"Gedcomx\\Tests\\Unit\\Conclusion\\RelationshipTests::testRelationshipGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Conclusion\\RelationshipTests::testRelationshipWithoutFacts":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\CommentTests::testCommentDeserialization":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\CommentTests::testCommentGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\CommentTests::testCommentWithoutContributor":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\DiscussionReferenceTests::testDiscussionReferenceGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\DiscussionReferenceTests::testDiscussionReferenceWithoutResourceId":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\DiscussionReferenceTests::testDiscussionReferenceEmpty":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\DiscussionTests::testDiscussionDeserialization":0.001,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\DiscussionTests::testDiscussionGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\DiscussionTests::testDiscussionWithoutComments":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\UserTests::testUserDeserialization":0.001,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\UserTests::testUserGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\UserTests::testUserWithMinimalData":0,"Gedcomx\\Unit\\GedcomxFileTests::testReadGedcomxFile":0.002,"Gedcomx\\Unit\\GedcomxFileTests::testXMLSerialization":0.002,"Gedcomx\\Unit\\GedcomxFileTests::testXMLDeserialization":0.001,"Gedcomx\\Unit\\GedcomxFileTests::testCreateGedxFile":0.003,"Gedcomx\\Tests\\Unit\\Source\\SourceCitationTests::testSourceCitationGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Source\\SourceCitationTests::testSourceCitationWithLanguage":0,"Gedcomx\\Tests\\Unit\\Source\\SourceCitationTests::testSourceCitationEmpty":0,"Gedcomx\\Tests\\Unit\\Source\\SourceDescriptionTests::testSourceDescriptionDeserialization":0.001,"Gedcomx\\Tests\\Unit\\Source\\SourceDescriptionTests::testSourceDescriptionGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Source\\SourceDescriptionTests::testSourceDescriptionWithoutCitations":0,"Gedcomx\\Tests\\Unit\\Source\\SourceReferenceTests::testSourceReferenceGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Source\\SourceReferenceTests::testSourceReferenceWithoutDescription":0,"Gedcomx\\Tests\\Unit\\Source\\SourceReferenceTests::testSourceReferenceWithAttribution":0,"Gedcomx\\Tests\\Unit\\XMLTests::testDeserializeXML":0,"Gedcomx\\Tests\\Unit\\Agent\\OnlineAccountTests::testOnlineAccountDeserialization":0,"Gedcomx\\Tests\\Unit\\Agent\\OnlineAccountTests::testOnlineAccountGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Agent\\OnlineAccountTests::testOnlineAccountWithoutServiceHomepage":0,"Gedcomx\\Tests\\Unit\\Conclusion\\DateInfoTests::testDateInfoDeserialization":0.001,"Gedcomx\\Tests\\Unit\\Conclusion\\DateInfoTests::testDateInfoGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Conclusion\\DateInfoTests::testDateInfoWithoutFormal":0,"Gedcomx\\Tests\\Unit\\Conclusion\\EventRoleTests::testEventRoleDeserialization":0,"Gedcomx\\Tests\\Unit\\Conclusion\\EventRoleTests::testEventRoleGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Conclusion\\EventRoleTests::testEventRoleWithoutDetails":0,"Gedcomx\\Tests\\Unit\\Conclusion\\IdentifierTests::testIdentifierDeserialization":0,"Gedcomx\\Tests\\Unit\\Conclusion\\IdentifierTests::testIdentifierGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Conclusion\\IdentifierTests::testIdentifierWithoutType":0,"Gedcomx\\Tests\\Unit\\Conclusion\\NameFormTests::testNameFormDeserialization":0.001,"Gedcomx\\Tests\\Unit\\Conclusion\\NameFormTests::testNameFormGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Conclusion\\NameFormTests::testNameFormWithoutParts":0,"Gedcomx\\Tests\\Unit\\Conclusion\\NamePartTests::testNamePartDeserialization":0,"Gedcomx\\Tests\\Unit\\Conclusion\\NamePartTests::testNamePartGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Conclusion\\NamePartTests::testNamePartWithoutType":0,"Gedcomx\\Tests\\Unit\\Conclusion\\PlaceReferenceTests::testPlaceReferenceDeserialization":0,"Gedcomx\\Tests\\Unit\\Conclusion\\PlaceReferenceTests::testPlaceReferenceGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Conclusion\\PlaceReferenceTests::testPlaceReferenceWithoutNormalized":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\ArtifactMetadataTests::testArtifactMetadataConstruction":0.001,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\ArtifactMetadataTests::testArtifactMetadataGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\ArtifactMetadataTests::testArtifactMetadataWithEmptyData":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\ChangeInfoTests::testChangeInfoDeserialization":0.001,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\ChangeInfoTests::testChangeInfoGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\ChangeInfoTests::testChangeInfoWithoutReason":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\MatchInfoTests::testMatchInfoDeserialization":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\MatchInfoTests::testMatchInfoGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\MatchInfoTests::testMatchInfoWithoutCollection":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\MergeAnalysisTests::testMergeAnalysisConstruction":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\MergeAnalysisTests::testMergeAnalysisGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\MergeAnalysisTests::testMergeAnalysisWithEmptyData":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\MergeConflictTests::testMergeConflictConstruction":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\MergeConflictTests::testMergeConflictGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\MergeConflictTests::testMergeConflictWithEmptyData":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\MergeTests::testMergeDeserialization":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\MergeTests::testMergeGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Extensions\\FamilySearch\\MergeTests::testMergeWithoutResources":0,"Gedcomx\\Tests\\Unit\\Source\\CitationFieldTests::testCitationFieldDeserialization":0,"Gedcomx\\Tests\\Unit\\Source\\CitationFieldTests::testCitationFieldGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Source\\CitationFieldTests::testCitationFieldEmpty":0,"Gedcomx\\Tests\\Unit\\Source\\CoverageTests::testCoverageDeserialization":0.001,"Gedcomx\\Tests\\Unit\\Source\\CoverageTests::testCoverageGettersAndSetters":0,"Gedcomx\\Tests\\Unit\\Source\\CoverageTests::testCoverageWithoutSpatial":0}}

README.md

@@ -93,12 +93,12 @@ The test suite passes without deprecation warnings on all supported PHP versions
 ### Test Coverage
 
 Current baseline:
-- 54 test cases with 147 assertions
-- Core models: Person, Gender, Fact, Name, Event, Relationship, Document, PlaceDescription
-- Agent models: Agent, Address
-- Source models: SourceDescription, SourceReference, SourceCitation
-- FamilySearch extensions: User, Discussion, Comment, DiscussionReference, ChildAndParentsRelationship
-- File format: GEDCOM X file (.gedx) read/write, XML serialization/deserialization
+- 99 test cases with 237 assertions
+- **Core models**: Person, Gender, Fact, Name, NameForm, NamePart, Event, EventRole, Relationship, Document, PlaceDescription, PlaceReference, DateInfo, Identifier
+- **Agent models**: Agent, Address, OnlineAccount
+- **Source models**: SourceDescription, SourceReference, SourceCitation, Coverage, CitationField
+- **FamilySearch extensions**: User, Discussion, Comment, DiscussionReference, ChildAndParentsRelationship, ChangeInfo, MatchInfo, Merge, MergeAnalysis, MergeConflict, ArtifactMetadata
+- **File format**: GEDCOM X file (.gedx) read/write, XML serialization/deserialization
 - See [TESTING.md](TESTING.md) for detailed coverage information and contributing guidelines
 
 For comprehensive testing documentation, see [TESTING.md](TESTING.md).

TESTING.md

@@ -62,39 +62,32 @@ vendor/bin/phpunit --coverage-clover build/logs/clover.xml
 
 Current test coverage baseline established:
 
-- **Test Files**: 17 test suites
-- **Test Cases**: 50+ tests covering core models and extensions
-- **Source Files**: 125 PHP files
-- **Core Models**: GEDCOM X conceptual model classes
-- **Extensions**: FamilySearch platform extensions
+- **Test Files**: 28 test suites
+- **Test Cases**: 99 tests with 237 assertions
+- **Source Files**: 125+ PHP files
+- **Core Models**: Complete GEDCOM X conceptual model class coverage
+- **Extensions**: Comprehensive FamilySearch platform extension coverage
 
 ### Coverage Areas
 
 #### Well-Covered Components (as of v3.2.0)
 
-- GEDCOM X file format (.gedx) reading and writing
-- XML serialization and deserialization
-- Core conclusion models: Person, Gender, Fact, Name, Event, Relationship, Document, PlaceDescription
-- Agent models: Agent, Address
-- Source models: SourceDescription, SourceReference, SourceCitation
-- FamilySearch extensions: User, Discussion, Comment, DiscussionReference, ChildAndParentsRelationship
+- **GEDCOM X file format**: .gedx reading and writing, XML serialization/deserialization
+- **Core conclusion models**: Person, Gender, Fact, Name, NameForm, NamePart, Event, EventRole, Relationship, Document, PlaceDescription, PlaceReference, DateInfo, Identifier
+- **Agent models**: Agent, Address, OnlineAccount
+- **Source models**: SourceDescription, SourceReference, SourceCitation, Coverage, CitationField
+- **FamilySearch extensions**: User, Discussion, Comment, DiscussionReference, ChildAndParentsRelationship, ChangeInfo, MatchInfo, Merge, MergeAnalysis, MergeConflict, ArtifactMetadata
 
 #### Areas for Future Expansion
 
 Additional test coverage could be added for:
 
-1. **Remaining GEDCOM X Core Models**
-   - Subject and Identifier models
-   - OnlineAccount model
-   - Coverage and CitationField models
-   - Standalone DateInfo and PlaceReference tests
+1. **Abstract/Base Classes**
+   - Subject and Conclusion base classes
+   - HasFacts trait
+   - DisplayProperties models
 
-2. **Additional FamilySearch Extensions**
-   - ChangeInfo, MatchInfo models
-   - Merge, MergeAnalysis, MergeConflict models
-   - ArtifactMetadata model
-
-3. **Serialization Edge Cases**
+2. **Serialization Edge Cases**
    - JSON serialization for all models (currently only XML is comprehensively tested)
    - Malformed data handling
    - Namespace handling for extensions
@@ -133,10 +126,13 @@ tests/
 
 Test fixtures are located in `tests/files/`:
 
-- **person.json**: Sample person data in JSON format
-- **record.xml**: Sample GEDCOM X record with extensions
-- **sample.gedx**: Complete GEDCOM X archive file
-- **cap-relationship-control.xml**: Expected XML output for relationships
+- **Core model fixtures**: person.json, gender.json, fact.json, name.json, date-info.json, identifier.json, name-form.json, name-part.json, event.json, event-role.json, relationship.json, document.json, place-description.json, place-reference.json
+- **Agent fixtures**: agent.json, address.json, online-account.json
+- **Source fixtures**: source-description.json, source-citation.json, coverage.json, citation-field.json
+- **FamilySearch extension fixtures**: user.json, discussion.json, comment.json, change-info.json, match-info.json, merge.json
+- **XML fixtures**: record.xml, cap-relationship-control.xml
+- **Archive files**: sample.gedx
+- **Test images**: test-image.jpg (for GEDX file tests)
 
 ### Base Test Class
 
@@ -167,9 +163,9 @@ The SDK is automatically tested on:
 - ✅ Return type declarations for interface implementations (ArrayAccess, Countable, IteratorAggregate)
 - ✅ Modern PHPUnit assertions (removed deprecated `assertEqualXMLStructure`)
 
-**Known External Deprecations**:
+**External Dependencies**:
 
-The `intervention/image` package (used only in tests for artifact generation) shows PHP 8+ deprecation warnings. These are outside our control and do not affect the SDK functionality.
+Test fixtures are used instead of runtime image generation, eliminating external dependencies and ensuring consistent test behavior across all PHP versions.
 
 ## Continuous Integration
 

composer.json

@@ -20,7 +20,6 @@
     "require-dev": {
         "phpunit/phpunit": "^9.5",
         "fakerphp/faker": "^1.9",
-        "intervention/image": "^2.7",
         "php-coveralls/php-coveralls": "^2.5"
     },
     "autoload": {

tests/ArtifactBuilder.php

@@ -2,8 +2,6 @@
 
 namespace Gedcomx\Tests;
 
-use Intervention\Image\ImageManagerStatic as Image;
-
 class ArtifactBuilder extends TestBuilder
 {
     private static $tempDir;
@@ -33,40 +31,20 @@ public static function makeTextFile()
     }
 
     /**
-     * Generate randomized images for testing
+     * Generate test images by copying a fixture
      * @return string The generated filename
      */
     public static function makeImage()
     {
-        $height = $width = 5;
-        $scale = 100;
         $filename = self::$tempDir . 'test_' . bin2hex(openssl_random_pseudo_bytes(8)) . ".jpg";
+        $fixtureImage = __DIR__ . '/files/test-image.jpg';
 
-        $img = Image::canvas($width, $height, '#000');
-        for ($x = 0; $x < $width; $x++) {
-            for ($y = 0; $y < $height; $y++) {
-                $color = self::randomColor();
-                $img->pixel($color, $x, $y);
-            }
+        if (!file_exists($fixtureImage)) {
+            throw new \RuntimeException('Test image fixture not found: ' . $fixtureImage);
         }
-        $img->resize($width * $scale, $width * $scale);
-        $png = $img->encode('jpg');
-        $png->save($filename);
 
-        return $filename;
-    }
+        copy($fixtureImage, $filename);
 
-    /**
-     * Generate random rgba color
-     * @return array
-     */
-    private static function randomColor()
-    {
-        return array(
-            mt_rand(0, 255),
-            mt_rand(0, 255),
-            mt_rand(0, 255),
-            1
-        );
+        return $filename;
     }
 }

tests/files/change-info.json

@@ -0,0 +1,6 @@
+{
+  "objectType": "Person",
+  "operation": "Create",
+  "reason": "Initial record creation",
+  "objectModifier": "Name"
+}

tests/files/citation-field.json

@@ -0,0 +1,4 @@
+{
+  "name": "volume",
+  "value": "Volume 12"
+}

tests/files/coverage.json

@@ -0,0 +1,10 @@
+{
+  "recordType": "http://gedcomx.org/Census",
+  "spatial": {
+    "original": "New York, United States"
+  },
+  "temporal": {
+    "original": "1900",
+    "formal": "+1900"
+  }
+}

tests/files/date-info.json

@@ -0,0 +1,10 @@
+{
+  "original": "January 1, 1900",
+  "formal": "+1900-01-01",
+  "normalized": [
+    {
+      "lang": "en-US",
+      "value": "1 January 1900"
+    }
+  ]
+}

tests/files/event-role.json

@@ -0,0 +1,7 @@
+{
+  "type": "http://gedcomx.org/Witness",
+  "person": {
+    "resource": "https://familysearch.org/platform/tree/persons/WITNESS-123"
+  },
+  "details": "Witnessed the marriage ceremony"
+}