Skip to content

Commit 5768932

Browse files
fancyholograms-v2: Only register listener for PlayerClientLoadedWorldEvent in 1.21.5 and 1.21.4
1 parent b02ec7c commit 5768932

3 files changed

Lines changed: 34 additions & 17 deletions

File tree

plugins/fancyholograms-v2/src/main/java/de/oliver/fancyholograms/FancyHolograms.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,7 @@
1818
import de.oliver.fancyholograms.commands.FancyHologramsTestCMD;
1919
import de.oliver.fancyholograms.commands.HologramCMD;
2020
import de.oliver.fancyholograms.hologram.version.*;
21-
import de.oliver.fancyholograms.listeners.BedrockPlayerListener;
22-
import de.oliver.fancyholograms.listeners.NpcListener;
23-
import de.oliver.fancyholograms.listeners.PlayerListener;
24-
import de.oliver.fancyholograms.listeners.WorldListener;
21+
import de.oliver.fancyholograms.listeners.*;
2522
import de.oliver.fancyholograms.storage.FlatFileHologramStorage;
2623
import de.oliver.fancyholograms.storage.converter.FHConversionRegistry;
2724
import de.oliver.fancyholograms.util.PluginUtils;
@@ -289,6 +286,9 @@ public void reloadCommands() {
289286
private void registerListeners() {
290287
getServer().getPluginManager().registerEvents(new PlayerListener(this), this);
291288
getServer().getPluginManager().registerEvents(new WorldListener(), this);
289+
if (Bukkit.getMinecraftVersion().equals("1.21.4") || Bukkit.getMinecraftVersion().equals("1.21.5")) {
290+
getServer().getPluginManager().registerEvents(new PlayerLoadedListener(), this);
291+
}
292292

293293
if (PluginUtils.isFancyNpcsEnabled()) {
294294
getServer().getPluginManager().registerEvents(new NpcListener(this), this);

plugins/fancyholograms-v2/src/main/java/de/oliver/fancyholograms/listeners/PlayerListener.java

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,11 @@
22

33
import de.oliver.fancyholograms.FancyHolograms;
44
import de.oliver.fancyholograms.api.hologram.Hologram;
5-
import io.papermc.paper.event.player.PlayerClientLoadedWorldEvent;
65
import org.bukkit.event.EventHandler;
76
import org.bukkit.event.EventPriority;
87
import org.bukkit.event.Listener;
9-
import org.bukkit.event.player.PlayerChangedWorldEvent;
10-
import org.bukkit.event.player.PlayerQuitEvent;
11-
import org.bukkit.event.player.PlayerResourcePackStatusEvent;
8+
import org.bukkit.event.player.*;
129
import org.bukkit.event.player.PlayerResourcePackStatusEvent.Status;
13-
import org.bukkit.event.player.PlayerTeleportEvent;
1410
import org.jetbrains.annotations.NotNull;
1511

1612
import java.util.*;
@@ -37,22 +33,23 @@ public PlayerListener(@NotNull final FancyHolograms plugin) {
3733
}
3834
}
3935

40-
@EventHandler(priority = EventPriority.MONITOR)
41-
public void onPlayerLoaded(@NotNull final PlayerClientLoadedWorldEvent event) {
42-
for (final Hologram hologram : this.plugin.getHologramsManager().getHolograms()) {
43-
hologram.forceUpdateShownStateFor(event.getPlayer());
44-
}
45-
}
46-
4736
@EventHandler(priority = EventPriority.MONITOR)
4837
public void onQuit(@NotNull final PlayerQuitEvent event) {
4938
FancyHolograms.get().getHologramThread().submit(() -> {
5039
for (final var hologram : this.plugin.getHologramsManager().getHolograms()) {
51-
hologram.hideHologram(event.getPlayer());
40+
hologram.forceHideHologram(event.getPlayer());
5241
}
5342
});
5443
}
5544

45+
@EventHandler(priority = EventPriority.MONITOR)
46+
public void onJoin(@NotNull final PlayerJoinEvent event) {
47+
for (final var hologram : this.plugin.getHologramsManager().getHolograms()) {
48+
hologram.forceHideHologram(event.getPlayer());
49+
hologram.forceUpdateShownStateFor(event.getPlayer());
50+
}
51+
}
52+
5653
@EventHandler(priority = EventPriority.MONITOR)
5754
public void onTeleport(@NotNull final PlayerTeleportEvent event) {
5855
for (final Hologram hologram : this.plugin.getHologramsManager().getHolograms()) {
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
package de.oliver.fancyholograms.listeners;
2+
3+
import de.oliver.fancyholograms.FancyHolograms;
4+
import de.oliver.fancyholograms.api.hologram.Hologram;
5+
import io.papermc.paper.event.player.PlayerClientLoadedWorldEvent;
6+
import org.bukkit.event.EventHandler;
7+
import org.bukkit.event.EventPriority;
8+
import org.bukkit.event.Listener;
9+
import org.jetbrains.annotations.NotNull;
10+
11+
public class PlayerLoadedListener implements Listener {
12+
13+
@EventHandler(priority = EventPriority.MONITOR)
14+
public void onPlayerLoaded(@NotNull final PlayerClientLoadedWorldEvent event) {
15+
for (final Hologram hologram : FancyHolograms.get().getHologramsManager().getHolograms()) {
16+
hologram.forceUpdateShownStateFor(event.getPlayer());
17+
}
18+
}
19+
20+
}

0 commit comments

Comments
 (0)