fn: Fix not trying to get username skins from cache first

Author: OliverSchlueter

plugins/fancynpcs/src/main/java/de/oliver/fancynpcs/skins/SkinManagerImpl.java

@@ -72,13 +72,7 @@ public SkinData getByIdentifier(String identifier, SkinData.SkinVariant variant)
             return getByIdentifier(parsed, variant);
         }
 
-        // is username
-        UUID uuid = UUIDFetcher.getUUID(identifier);
-        if (uuid == null) {
-            throw new SkinLoadException(SkinLoadException.Reason.INVALID_USERNAME, "(USERNAME = '" + identifier + "')");
-        }
-
-        return getByUUID(uuid, variant);
+        return getByUsername(identifier, variant);
     }
 
     @Override
@@ -98,12 +92,18 @@ public SkinData getByUUID(UUID uuid, SkinData.SkinVariant variant) {
 
     @Override
     public SkinData getByUsername(String username, SkinData.SkinVariant variant) throws SkinLoadException {
+        SkinData cached = tryToGetFromCache(username, variant);
+        if (cached != null) {
+            return cached;
+        }
+
         UUID uuid = UUIDFetcher.getUUID(username);
         if (uuid == null) {
             throw new SkinLoadException(SkinLoadException.Reason.INVALID_USERNAME, "(USERNAME = '" + username + "')");
         }
+        SkinData dataByUUID = getByUUID(uuid, variant);
 
-        return getByUUID(uuid, variant);
+        return new SkinData(username, dataByUUID.getVariant(), dataByUUID.getTextureValue(), dataByUUID.getTextureSignature());
     }
 
     @Override