fancydialogs: Refactor FancyNpcs integration

Author: OliverSchlueter

plugins/fancydialogs/build.gradle.kts

@@ -93,11 +93,11 @@ tasks {
         minecraftVersion("1.21.6")
 
         downloadPlugins {
-            modrinth("fancynpcs", "2.5.0")
-            hangar("ViaVersion", "5.3.2")
-            hangar("ViaBackwards", "5.3.2")
+//            modrinth("fancynpcs", "2.5.0")
+//            hangar("ViaVersion", "5.3.2")
+//            hangar("ViaBackwards", "5.3.2")
 //            modrinth("multiverse-core", "4.3.11")
-            hangar("PlaceholderAPI", "2.11.6")
+//            hangar("PlaceholderAPI", "2.11.6")
         }
     }
 

plugins/fancydialogs/src/main/java/com/fancyinnovations/fancydialogs/FancyDialogsPlugin.java

@@ -141,7 +141,9 @@ public void onEnable() {
         registerCommands();
 
         // FancyNpcs actions
-        new OpenDialogNpcAction().register();
+        if (Bukkit.getPluginManager().isPluginEnabled("FancyNpcs")) {
+            new OpenDialogNpcAction().register();
+        }
 
         fancyLogger.info("Successfully enabled FancyDialogs version %s".formatted(getDescription().getVersion()));
     }

plugins/fancydialogs/src/main/java/com/fancyinnovations/fancydialogs/fancynpcs/OpenDialogNpcAction.java

@@ -5,7 +5,6 @@
 import de.oliver.fancynpcs.api.FancyNpcsPlugin;
 import de.oliver.fancynpcs.api.actions.NpcAction;
 import de.oliver.fancynpcs.api.actions.executor.ActionExecutionContext;
-import org.bukkit.Bukkit;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
@@ -27,9 +26,7 @@ public void execute(@NotNull ActionExecutionContext context, @Nullable String va
     }
 
     public void register() {
-        if (Bukkit.getPluginManager().isPluginEnabled("FancyNpcs")) {
-            FancyNpcsPlugin.get().getActionManager().registerAction(this);
-            FancyDialogsPlugin.get().getFancyLogger().info("Registered NPC action 'open_dialog' for FancyNpcs.");
-        }
+        FancyNpcsPlugin.get().getActionManager().registerAction(this);
+        FancyDialogsPlugin.get().getFancyLogger().info("Registered NPC action 'open_dialog' for FancyNpcs.");
     }
 }