Remove previous filtered deck options related code

Author: lukstbit

AnkiDroid/src/main/AndroidManifest.xml

@@ -401,13 +401,6 @@
                 <category android:name="android.intent.category.MONKEY" />
             </intent-filter>
         </activity>
-        <activity
-            android:name=".FilteredDeckOptions"
-            android:label="@string/deckpreferences_title"
-            android:exported="false"
-            android:configChanges="keyboardHidden|orientation|screenSize"
-            android:theme="@style/Theme_Light"
-            />
         <activity
             android:name="com.ichi2.anki.Info"
             android:label="@string/pref_cat_about_title"

AnkiDroid/src/main/java/com/ichi2/anki/FilteredDeckOptions.kt

@@ -24,7 +24,6 @@ import androidx.annotation.VisibleForTesting
 import androidx.appcompat.app.AlertDialog
 import com.google.android.material.snackbar.Snackbar
 import com.ichi2.anki.CollectionManager
-import com.ichi2.anki.CollectionManager.withCol
 import com.ichi2.anki.R
 import com.ichi2.anki.common.annotations.NeedsTest
 import com.ichi2.anki.libanki.Collection
@@ -62,7 +61,6 @@ class CreateDeckDialog(
     private var shownDialog: AlertDialog? = null
 
     enum class DeckDialogType {
-        FILTERED_DECK,
         DECK,
         SUB_DECK,
         RENAME_DECK,
@@ -71,15 +69,6 @@ class CreateDeckDialog(
     private val getColUnsafe
         get() = CollectionManager.getColUnsafe()
 
-    suspend fun showFilteredDeckDialog() {
-        Timber.i("CreateDeckDialog::showFilteredDeckDialog")
-        initialDeckName =
-            withCol {
-                sched.getOrCreateFilteredDeck(did = 0).name
-            }
-        showDialog()
-    }
-
     /** Used for rename  */
     var deckName: String
         get() = shownDialog!!.getInputField().text.toString()
@@ -102,7 +91,6 @@ class CreateDeckDialog(
 
                             DeckDialogType.DECK,
                             DeckDialogType.SUB_DECK,
-                            DeckDialogType.FILTERED_DECK,
                             -> R.string.dialog_positive_create
                         }
                     positiveButton(positiveButtonTextRes) {
@@ -181,7 +169,7 @@ class CreateDeckDialog(
      */
     private fun fullyQualifyDeckName(dialogText: CharSequence) =
         when (deckDialogType) {
-            DeckDialogType.DECK, DeckDialogType.FILTERED_DECK, DeckDialogType.RENAME_DECK -> dialogText.toString()
+            DeckDialogType.DECK, DeckDialogType.RENAME_DECK -> dialogText.toString()
             DeckDialogType.SUB_DECK -> getColUnsafe.decks.getSubdeckName(parentId!!, dialogText.toString())
         }
 
@@ -206,34 +194,6 @@ class CreateDeckDialog(
         shownDialog?.dismiss()
     }
 
-    fun createFilteredDeck(deckName: String): Boolean {
-        fun validFilteredDeckName(initialName: String): String {
-            for (i in 0..10) {
-                val name = initialName + "+".repeat(i)
-                if (getColUnsafe.decks.byName(name) == null) return name
-            }
-            throw IllegalStateException("Could not generate valid name")
-        }
-
-        try {
-            // create filtered deck
-            Timber.i("CreateDeckDialog::createFilteredDeck...")
-            val newDeckId = getColUnsafe.decks.newFiltered(validFilteredDeckName(deckName))
-            Timber.d("Created filtered deck '%s'; id: %d", deckName, newDeckId)
-            onNewDeckCreated(newDeckId)
-        } catch (ex: IllegalStateException) {
-            if (ex.message != "Could not generate valid name") {
-                throw ex
-            }
-            displayFeedback(ex.localizedMessage ?: ex.message ?: "", Snackbar.LENGTH_LONG)
-            return false
-        } catch (ex: BackendDeckIsFilteredException) {
-            displayFeedback(ex.localizedMessage ?: ex.message ?: "", Snackbar.LENGTH_LONG)
-            return false
-        }
-        return true
-    }
-
     private fun createNewDeck(deckName: String): Boolean {
         try {
             // create normal deck or sub deck
@@ -262,10 +222,6 @@ class CreateDeckDialog(
                     // create sub deck
                     createSubDeck(parentId!!, deckName)
                 }
-                DeckDialogType.FILTERED_DECK -> {
-                    // create filtered deck
-                    createFilteredDeck(deckName)
-                }
             }
         }
     }

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/CreateDeckDialog.kt

@@ -28,14 +28,12 @@ import androidx.core.graphics.drawable.toDrawable
 import androidx.core.view.WindowInsetsControllerCompat
 import androidx.fragment.app.FragmentActivity
 import com.google.android.material.color.MaterialColors
-import com.ichi2.anki.AnkiDroidApp
 import com.ichi2.anki.R
 import com.ichi2.anki.settings.PrefsRepository
 import com.ichi2.anki.settings.enums.AppTheme
 import com.ichi2.anki.settings.enums.DayTheme
 import com.ichi2.anki.settings.enums.NightTheme
 import com.ichi2.anki.settings.enums.Theme
-import com.ichi2.ui.AppCompatPreferenceActivity
 
 /**
  * Helper methods to configure things related to AnkiDroid's themes
@@ -63,16 +61,7 @@ object Themes {
      * Otherwise, updates to the selected theme.
      */
     fun updateCurrentTheme(context: Context) {
-        // AppCompatPreferenceActivity's sharedPreferences is initialized
-        // after the time when the theme should be set
-        // TODO (#5019): always use the context as the parameter for getSharedPrefs
-        val prefsContext =
-            if (context is AppCompatPreferenceActivity<*>) {
-                AnkiDroidApp.instance
-            } else {
-                context
-            }
-        val prefs = PrefsRepository(prefsContext)
+        val prefs = PrefsRepository(context)
         val appTheme = prefs.appTheme
 
         val themeIsDark = (appTheme == AppTheme.FOLLOW_SYSTEM && systemIsInNightMode(context)) || appTheme == AppTheme.NIGHT