feat(card-browser): exclude empty search history entries

Author: david-allison

AnkiDroid/src/main/java/com/ichi2/anki/browser/SearchHistory.kt

@@ -57,6 +57,10 @@ class SearchHistory(
      */
     fun addRecent(entry: SearchHistoryEntry): List<SearchHistoryEntry> {
         val updatedEntries = entries.toMutableList()
+        if (entry.isSearchEmpty()) {
+            Timber.d("skipping updating history with no search")
+            return updatedEntries
+        }
         updatedEntries.remove(entry)
         updatedEntries.add(0, entry)
         return updatedEntries.take(maxEntries).also {
@@ -93,6 +97,12 @@ class SearchHistory(
         val query: String,
     ) {
         override fun toString() = query
+
+        /**
+         * Whether there is no set search - effectively a search for the default search:
+         * `deck:*`
+         */
+        fun isSearchEmpty() = query.isBlank()
     }
 
     companion object {

AnkiDroid/src/test/java/com/ichi2/anki/browser/SearchHistoryTest.kt

@@ -121,6 +121,13 @@ class SearchHistoryTest : RobolectricTest() {
         assertThat(history.entries.single().query, equalTo("1"))
     }
 
+    @Test
+    fun `blank entries are not persisted`() {
+        history.addRecent(SearchHistoryEntry(""))
+        history.addRecent(SearchHistoryEntry(" "))
+        assertThat(history.entries, empty())
+    }
+
     /** Adds numbered entries from 1 to [count] inclusive */
     fun addNumberedEntries(count: Int) =
         repeat(count) {