Skip to content

Commit ed5cc00

Browse files
committed
test: update WebViewUtilsTest to use accurate webview version data
1 parent e510f2c commit ed5cc00

1 file changed

Lines changed: 3 additions & 15 deletions

File tree

AnkiDroid/src/test/java/com/ichi2/utils/WebViewUtilsTest.kt

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -56,26 +56,14 @@ class WebViewUtilsTest {
5656
equalTo(null),
5757
)
5858
assertThat(
59-
"Should catch old engine (78) in Huawei package even with valid versionCode",
59+
"Known old huawei webview determined correctly",
6060
checkWebViewVersionComponents(
6161
"com.huawei.webview",
62-
"12.1.2.322",
63-
450000000L,
62+
"unknown",
63+
356L,
6464
"Mozilla/5.0 (Linux; Android 10; CDY-AN90 Build/HUAWEICDY-AN90; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/78.0.3904.108 Mobile Safari/537.36",
6565
),
6666
equalTo(78),
6767
)
68-
// Link: https://www.apkmirror.com/apk/huawei/huawei-webview-2/huawei-webview-15-0-4-326-release/
69-
// verified version code is 2113L for 15.0.4.326 by analyzing the manifest
70-
assertThat(
71-
"Huawei v15 with code 21311 should be allowed if UA indicates modern engine (114)",
72-
checkWebViewVersionComponents(
73-
"com.huawei.webview",
74-
"15.0.4.326",
75-
21311L,
76-
"Mozilla/5.0 (Linux; Android 12; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/114.0.5735.196 Mobile Safari/537.36",
77-
),
78-
equalTo(null),
79-
)
8068
}
8169
}

0 commit comments

Comments
 (0)