Skip to content

Commit 0a13e62

Browse files
committed
simplify logic slightly
1 parent bf7510a commit 0a13e62

1 file changed

Lines changed: 15 additions & 16 deletions

File tree

qcodes/instrument/delegate/delegate_instrument.py

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -168,29 +168,28 @@ def _create_and_add_parameters(
168168
station: Station,
169169
parameters: Union[Mapping[str, Sequence[str]], Mapping[str, str]],
170170
setters: Mapping[str, MutableMapping[str, Any]],
171-
units: Dict[str, str]
171+
units: Mapping[str, str],
172172
) -> None:
173173
"""Add parameters to delegate instrument based on specified aliases,
174174
endpoints and setter methods"""
175175
for param_name, paths in parameters.items():
176176
if isinstance(paths, str):
177-
self._create_and_add_parameter(
178-
group_name=param_name,
179-
station=station,
180-
paths=[paths],
181-
setter=setters.get(param_name),
182-
unit=units.get(param_name)
183-
)
177+
path_list: Sequence[str] = [paths]
178+
184179
elif isinstance(paths, abc.Sequence):
185-
self._create_and_add_parameter(
186-
group_name=param_name,
187-
station=station,
188-
paths=paths,
189-
setter=setters.get(param_name),
190-
unit=units.get(param_name)
191-
)
180+
path_list = paths
192181
else:
193-
raise ValueError("Parameter paths should be either a string or list of strings.")
182+
raise ValueError(
183+
"Parameter paths should be either a string or Sequence of strings."
184+
)
185+
186+
self._create_and_add_parameter(
187+
group_name=param_name,
188+
station=station,
189+
paths=path_list,
190+
setter=setters.get(param_name),
191+
unit=units.get(param_name),
192+
)
194193

195194
@staticmethod
196195
def _parameter_names(parameters: Sequence[Parameter]) -> List[str]:

0 commit comments

Comments
 (0)