changed mode numbers for pong and surround#397
Conversation
|
@weepingwillowben do you have any sense of how aligned other modes are with their manual, i.e., 1-indexed with the proper indices? |
|
@JesseFarebro A few were indexed in more bizarre manners, for example Surround's modes currently start at -1. Some of those were fixed by #365. Then there are a few environments that do have modes in ALE, but not in the game manual, such as double dunk. |
1e67fe1 to
8f3bc3b
Compare
fff79cf to
a16a993
Compare
a42e8ad to
4642385
Compare
|
Would you be willing to create a new version of this PR with the merge conflicts fixed so it can be reviewed as part of our ongoing work to get the multi-agent ALE stuff merged in? |
This fixes the surround and pong game modes to align with the manual, as per discussion here #366.