Skip to content

changed mode numbers for pong and surround#397

Closed
benblack769 wants to merge 1 commit into
mainfrom
modes_pr
Closed

changed mode numbers for pong and surround#397
benblack769 wants to merge 1 commit into
mainfrom
modes_pr

Conversation

@benblack769

Copy link
Copy Markdown
Contributor

This fixes the surround and pong game modes to align with the manual, as per discussion here #366.

@JesseFarebro

Copy link
Copy Markdown
Contributor

@weepingwillowben do you have any sense of how aligned other modes are with their manual, i.e., 1-indexed with the proper indices?

@benblack769

Copy link
Copy Markdown
Contributor Author

@JesseFarebro
My understanding is that most of the environments are currently 0 indexed, even though the manual is 1 indexed. Pong is an example of this. Pong is important to us because there are so many interesting multi-player modes in it.

A few were indexed in more bizarre manners, for example Surround's modes currently start at -1. Some of those were fixed by #365.

Then there are a few environments that do have modes in ALE, but not in the game manual, such as double dunk.

@jkterry1

Copy link
Copy Markdown
Member

@Sebastian-Griesbach

Would you be willing to create a new version of this PR with the merge conflicts fixed so it can be reviewed as part of our ongoing work to get the multi-agent ALE stuff merged in?

@Sebastian-Griesbach

Copy link
Copy Markdown

@jkterry1 The updated PR is #712

@jkterry1 jkterry1 closed this Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants