Skip to content

Typescript errors in v3.3.2 with strict typechecking #2712

@cashc

Description

@cashc

My tests are failing because of typescript errors in this package.

Running tsc command with my tsconfig that has "strict": true and "noUncheckedIndexedAccess": true yields these errors:

Found 23 errors in 10 files.

Errors  Files
     1  node_modules/react-native-gifted-chat/src/Actions.tsx:59
     1  node_modules/react-native-gifted-chat/src/Bubble/index.tsx:376
     1  node_modules/react-native-gifted-chat/src/Composer.tsx:76
     3  node_modules/react-native-gifted-chat/src/GiftedAvatar.tsx:66
     1  node_modules/react-native-gifted-chat/src/Message/index.tsx:179
     6  node_modules/react-native-gifted-chat/src/MessagesContainer/components/DayAnimated/index.tsx:42
     3  node_modules/react-native-gifted-chat/src/MessagesContainer/components/Item/index.tsx:45
     3  node_modules/react-native-gifted-chat/src/MessagesContainer/index.tsx:176
     1  node_modules/react-native-gifted-chat/src/Time.tsx:56
     3  node_modules/react-native-zoom-reanimated/src/index.tsx:562

and running it with just "strict": true (removing noUncheckedIndexedAccess) yields:

Found 5 errors in 5 files.

Errors  Files
     1  node_modules/react-native-gifted-chat/src/Bubble/index.tsx:376
     1  node_modules/react-native-gifted-chat/src/Composer.tsx:76
     1  node_modules/react-native-gifted-chat/src/Message/index.tsx:179
     1  node_modules/react-native-gifted-chat/src/Time.tsx:56
     1  node_modules/react-native-zoom-reanimated/src/index.tsx:1060

It seems this is a regression since this same issue was created and apparently fixed by #2698. However, the latest version v3.3.2 is still showing errors.

I believe this is will be an easy fix of adding some ?s on variables that could possibly be undefined and fixing some TextStyles that should be ViewStyles.

Thank you for your work 🙏🏼

Best,
Cash

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions