feat: add keyboardBottomOffset prop for Android keyboard issues#2734
Open
TeapoyY wants to merge 1 commit intoFaridSafi:masterfrom
Open
feat: add keyboardBottomOffset prop for Android keyboard issues#2734TeapoyY wants to merge 1 commit intoFaridSafi:masterfrom
TeapoyY wants to merge 1 commit intoFaridSafi:masterfrom
Conversation
Re-add keyboardBottomOffset prop that was removed during keyboard handling refactor. Useful on Android when using expo-router or other navigation setups where the keyboard may still cover the input toolbar even with correct keyboardVerticalOffset. Fixes FaridSafi#2469
|
perfect, which i was facing yesterday, thank. can we merge it asap! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-adds the keyboardBottomOffset prop that was previously removed during a keyboard handling refactor. This prop allows users to add extra bottom padding to the KeyboardAvoidingView, which is useful on Android when using expo-router or other navigation setups where the keyboard may still cover the input toolbar.
Changes
src/GiftedChat/types.ts
src/GiftedChat/index.tsx