fix rake task warnings

Author: gabrielburnworth

lib/tasks/check_file_coverage.rake

@@ -3,6 +3,45 @@ require 'find'
 
 API_COVERAGE_INDEX = File.join('coverage_api', 'index.html')
 
+def normalize_frontend_path(path, frontend_root)
+  return path if path.start_with?(frontend_root + "/")
+  return path.sub(%r{^.*?/frontend/}, frontend_root + "/") if path.include?("/frontend/")
+  path
+end
+
+def load_lcov_coverage(path, frontend_root)
+  return {} unless File.exist?(path)
+  files = {}
+  current = nil
+  File.foreach(path) do |raw_line|
+    line = raw_line.strip
+    case line
+    when /^SF:(.+)/
+      file_path = normalize_frontend_path(Regexp.last_match(1), frontend_root)
+      current = files[file_path] = {
+        lines: { covered: 0, total: 0 },
+        branches: { covered: 0, total: 0 },
+        functions: { covered: 0, total: 0 },
+      }
+    when /^LH:(\d+)/
+      current[:lines][:covered] = Regexp.last_match(1).to_i if current
+    when /^LF:(\d+)/
+      current[:lines][:total] = Regexp.last_match(1).to_i if current
+    when /^BRH:(\d+)/
+      current[:branches][:covered] = Regexp.last_match(1).to_i if current
+    when /^BRF:(\d+)/
+      current[:branches][:total] = Regexp.last_match(1).to_i if current
+    when /^FNH:(\d+)/
+      current[:functions][:covered] = Regexp.last_match(1).to_i if current
+    when /^FNF:(\d+)/
+      current[:functions][:total] = Regexp.last_match(1).to_i if current
+    when "end_of_record"
+      current = nil
+    end
+  end
+  files
+end
+
 namespace :check_file_coverage do
   desc "Check test coverage for one or more app files after running `rspec`. " +
        "Usage: rake check_file_coverage:api app/models/device.rb"
@@ -72,61 +111,22 @@ namespace :check_file_coverage do
   desc "Check frontend file coverage after running `bun test`. " +
        "Usage: rake check_file_coverage:frontend frontend/app.tsx"
   task fe: :environment do
-    FRONTEND_ROOT = 'frontend'
-    COVERAGE_ROOT = 'coverage_fe'
-    LCOV_FILE_PATH = File.join(COVERAGE_ROOT, 'lcov.info')
+    frontend_root = 'frontend'
+    coverage_root = 'coverage_fe'
+    lcov_file_path = File.join(coverage_root, 'lcov.info')
 
     task_name = Rake.application.top_level_tasks.first
     task_index = ARGV.index(task_name)
     paths_args = ARGV.drop(task_index + 1)
 
-    def normalize_frontend_path(path)
-      return path if path.start_with?(FRONTEND_ROOT + "/")
-      return path.sub(%r{^.*?/frontend/}, FRONTEND_ROOT + "/") if path.include?("/frontend/")
-      path
-    end
-
-    def load_lcov_coverage(path)
-      return {} unless File.exist?(path)
-      files = {}
-      current = nil
-      File.foreach(path) do |raw_line|
-        line = raw_line.strip
-        case line
-        when /^SF:(.+)/
-          file_path = normalize_frontend_path(Regexp.last_match(1))
-          current = files[file_path] = {
-            lines: { covered: 0, total: 0 },
-            branches: { covered: 0, total: 0 },
-            functions: { covered: 0, total: 0 },
-          }
-        when /^LH:(\d+)/
-          current[:lines][:covered] = Regexp.last_match(1).to_i if current
-        when /^LF:(\d+)/
-          current[:lines][:total] = Regexp.last_match(1).to_i if current
-        when /^BRH:(\d+)/
-          current[:branches][:covered] = Regexp.last_match(1).to_i if current
-        when /^BRF:(\d+)/
-          current[:branches][:total] = Regexp.last_match(1).to_i if current
-        when /^FNH:(\d+)/
-          current[:functions][:covered] = Regexp.last_match(1).to_i if current
-        when /^FNF:(\d+)/
-          current[:functions][:total] = Regexp.last_match(1).to_i if current
-        when "end_of_record"
-          current = nil
-        end
-      end
-      files
-    end
-
-    lcov_coverage = load_lcov_coverage(LCOV_FILE_PATH)
+    lcov_coverage = load_lcov_coverage(lcov_file_path, frontend_root)
     abort("Run `bun test` first.") if lcov_coverage.empty?
 
     if paths_args.empty?
       paths = lcov_coverage.keys
     else
       paths = paths_args.map do |path|
-        normalize_frontend_path(path.sub(%r{^#{Regexp.escape(COVERAGE_ROOT)}/}, ''))
+        normalize_frontend_path(path.sub(%r{^#{Regexp.escape(coverage_root)}/}, ''), frontend_root)
       end
     end