don't add plant/point/weed after orbit drag release

Author: roryaronson

frontend/three_d_garden/bed/objects/__tests__/pointer_objects_test.tsx

@@ -16,6 +16,7 @@ import {
 import { render } from "@testing-library/react";
 import { INITIAL } from "../../../config";
 import { fakeAddPlantProps } from "../../../../__test_support__/fake_props";
+import { fakeDrawnPoint } from "../../../../__test_support__/fake_designer_state";
 import { clone } from "lodash";
 import { Path } from "../../../../internal_urls";
 import { Vector3 } from "three";
@@ -130,6 +131,42 @@ describe("soilClick()", () => {
       gardenCoords: { x: 1360, y: 660 },
     }));
   });
+
+  it("doesn't create a plant after a drag", () => {
+    location.pathname = Path.mock(Path.cropSearch("mint"));
+    mockIsMobile = false;
+    const p = fakeProps();
+    const e = {
+      stopPropagation: jest.fn(),
+      point: { x: 1, y: 2 },
+      delta: 3,
+    } as unknown as ThreeEvent<MouseEvent>;
+    soilClick(p)(e);
+    expect(e.stopPropagation).toHaveBeenCalled();
+    expect(dropPlantSpy).not.toHaveBeenCalled();
+  });
+
+  it.each([
+    ["point", Path.points("add")],
+    ["weed", Path.weeds("add")],
+  ])("doesn't set %s location after a drag", (_label, path) => {
+    location.pathname = Path.mock(path);
+    mockIsMobile = false;
+    const p = fakeProps();
+    const point = fakeDrawnPoint();
+    point.cx = undefined;
+    point.cy = undefined;
+    point.r = 0;
+    p.addPlantProps.designer.drawnPoint = point;
+    const e = {
+      stopPropagation: jest.fn(),
+      point: { x: 1, y: 2 },
+      delta: 3,
+    } as unknown as ThreeEvent<MouseEvent>;
+    soilClick(p)(e);
+    expect(e.stopPropagation).toHaveBeenCalled();
+    expect(p.addPlantProps.dispatch).not.toHaveBeenCalled();
+  });
 });
 
 describe("soilPointerMove()", () => {

frontend/three_d_garden/bed/objects/pointer_objects.tsx

@@ -178,11 +178,14 @@ export interface SoilClickProps {
   getZ(x: number, y: number): number;
 }
 
+export const MAX_SOIL_CLICK_DELTA = 2;
+
 export const soilClick = (props: SoilClickProps) =>
   (e: ThreeEvent<MouseEvent>) => {
     const { config, navigate, addPlantProps, pointerPlantRef } = props;
     const getGardenPosition = getGardenPositionFunc(config);
     e.stopPropagation();
+    if ((e.delta || 0) > MAX_SOIL_CLICK_DELTA) { return; }
     if (addPlantProps) {
       if (getMode() == Mode.clickToAdd) {
         dropPlant({