Added support for BSON#2
Open
RoBoT095 wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
Trying to use my fork in my own project, it would probably be better to change the serialization and deserialization from BsonBinary to List so it would be easier to do I'll see about changing this later myself. |
Contributor
Author
|
My bad, I did the mistake of merging scroll controller into this branch, my fault for making this pull request be my main, instead of a separate branch. I know it won't be an issue, but I prefer to keep things clean. Also, I just suck at git and github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to #1, this isn't a full integration of it and mostly a wrapper for
SketchDataConverter.toJson()so you don't exactly get all the speed benefits, as you are still dealing with json. This is purely for supporting the BSON format.It probably needs more testing as I haven't tried the model > content > shape/draw overrides, ex:
But the SketchDataConverter and SketchController seem to work just fine.
I still recommend for you to go through it and clean it up as you like, I am honestly not very familiar with all the workings of BSON, but I did my best.