Commit a409c4c
committed
fix(symbols): annotate c++filt direct spawn for find_direct_subprocess.py
PR #424's "Lint subprocess spawns" CI runs both a dylint rule (file-
level allowlist, already added) AND a separate Python script
`ci/find_direct_subprocess.py` that scans for `Command::new(...)` and
requires an inline `// allow-direct-spawn: <reason>` comment on the
line above each call. The dylint allowlist alone is not enough — both
gates must pass independently.
Add the inline annotation above the c++filt spawn in
`fbuild-build::symbol_analyzer::demangle_batch` matching the format
used elsewhere in the tree (see e.g. fbuild-cli/src/daemon_client.rs).
Same rationale as the dylint allowlist entry: stdin-piped + threaded
writer is required to avoid the Windows pipe-buffer deadlock when
demangling thousands of names.1 parent 11ea206 commit a409c4c
1 file changed
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
76 | 82 | | |
77 | 83 | | |
78 | 84 | | |
| |||
0 commit comments