fix(ci): drop unsupported continue-on-error from LPC8xx workflows (#453)

`build-lpc804.yml` and `build-lpc845.yml` set `continue-on-error: true`
on a job that calls a reusable workflow (`uses: ./.github/workflows/
template_build.yml`). That keyword is not in the allow-list for
reusable-workflow caller jobs, so every push to main went red with
"workflow file issue" before any job ran (30/30 recent runs on each).

Run that triggered this fix:
  https://github.com/FastLED/fbuild/actions/runs/27073787763

Allow-list reference:
  https://docs.github.com/en/actions/sharing-automations/reusing-workflows#supported-keywords-for-jobs-that-call-a-reusable-workflow

Fix is just dropping the unsupported keyword — the workflows now have
the same structure as the working `build-esp32c6.yml` sibling. The
"non-blocking on main" intent in the original comment is preserved by
not adding these workflows to branch protection's required-checks
list; the inline comment is updated to call that out so the next
visitor doesn't reach for `continue-on-error` again.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: zackees

.github/workflows/build-lpc804.yml

@@ -3,9 +3,15 @@ name: Build LPC804
 # Stage 1 of FastLED/FastLED#2836: build/toolchain wiring lands now, the
 # actual Stage-2 LPC8xx orchestrator lands in a follow-up FastLED-side PR.
 # Until Stage 2 lands, this workflow's `fbuild build` step fails fast with
-# a "Stage 2 required" error. `continue-on-error: true` keeps the overall
-# check status non-blocking on `main` while still surfacing red runs on the
-# Actions tab. Remove `continue-on-error` once Stage 2 lands.
+# a "Stage 2 required" error.
+#
+# This workflow stays out of branch protection's required-checks list, so
+# a red run here doesn't block merges on `main`. The previous attempt used
+# `continue-on-error: true` on the calling job, but that keyword is NOT in
+# the allow-list for jobs that call a reusable workflow — every push to
+# main went red with "workflow file issue" before any job actually ran.
+# See:
+# https://docs.github.com/en/actions/sharing-automations/reusing-workflows#supported-keywords-for-jobs-that-call-a-reusable-workflow
 
 on:
   workflow_dispatch: {}
@@ -16,7 +22,6 @@ on:
 
 jobs:
   build:
-    continue-on-error: true
     uses: ./.github/workflows/template_build.yml
     with:
       workflow-name: "NXP LPC804"

.github/workflows/build-lpc845.yml

@@ -3,9 +3,15 @@ name: Build LPC845
 # Stage 1 of FastLED/FastLED#2836: build/toolchain wiring lands now, the
 # actual Stage-2 LPC8xx orchestrator lands in a follow-up FastLED-side PR.
 # Until Stage 2 lands, this workflow's `fbuild build` step fails fast with
-# a "Stage 2 required" error. `continue-on-error: true` keeps the overall
-# check status non-blocking on `main` while still surfacing red runs on the
-# Actions tab. Remove `continue-on-error` once Stage 2 lands.
+# a "Stage 2 required" error.
+#
+# This workflow stays out of branch protection's required-checks list, so
+# a red run here doesn't block merges on `main`. The previous attempt used
+# `continue-on-error: true` on the calling job, but that keyword is NOT in
+# the allow-list for jobs that call a reusable workflow — every push to
+# main went red with "workflow file issue" before any job actually ran.
+# See:
+# https://docs.github.com/en/actions/sharing-automations/reusing-workflows#supported-keywords-for-jobs-that-call-a-reusable-workflow
 
 on:
   workflow_dispatch: {}
@@ -16,7 +22,6 @@ on:
 
 jobs:
   build:
-    continue-on-error: true
     uses: ./.github/workflows/template_build.yml
     with:
       workflow-name: "NXP LPC845"