Skip to content

Commit c6cc8c4

Browse files
zackeesclaude
andcommitted
ci: defer ban_raw_subprocess dylint to follow-up issue
Per CR feedback on PR #262 the dylint needs zccache's build_dylint_driver.py infrastructure (published dylint_driver 5.0.0 doesn't build against nightly-2026-03-26) plus a tightened scope filter and qpath handling. That's enough scope to warrant its own PR. Strip the dylint crate, the workspace metadata + exclude entries, and the CI step. Keep the user-facing LTO fix (the actual bug from issue #261). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 634e9e5 commit c6cc8c4

9 files changed

Lines changed: 0 additions & 1882 deletions

File tree

.github/workflows/check-ubuntu.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,5 @@ jobs:
3333
run: soldr cargo clippy --workspace --all-targets -- -D warnings
3434
- name: Lint subprocess spawns
3535
run: uv run python ci/find_direct_subprocess.py --fail
36-
# Custom dylint enforces the rule that all subprocess spawns go
37-
# through the wrappers in `fbuild_core::{subprocess,containment}`.
38-
# See `dylints/ban_raw_subprocess/`. The dylint crate has its
39-
# own nightly toolchain (rust-toolchain.toml inside the dir);
40-
# `cargo dylint` picks it up automatically.
41-
- name: Install cargo-dylint
42-
run: cargo install cargo-dylint dylint-link --locked
43-
- name: Run ban_raw_subprocess dylint
44-
run: cargo dylint --all -- --workspace --all-targets
4536
- name: Test
4637
run: soldr cargo test --workspace

Cargo.toml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,6 @@ members = [
1616
"crates/fbuild-library-select",
1717
"bench/fastled-examples",
1818
]
19-
exclude = [
20-
# Dylint lints live in their own nightly toolchain — see each
21-
# dylint's rust-toolchain.toml. Not part of the workspace build.
22-
"dylints/ban_raw_subprocess",
23-
]
24-
25-
[workspace.metadata.dylint]
26-
libraries = [{ path = "dylints/*" }]
2719

2820
[workspace.package]
2921
version = "2.2.4"

dylints/ban_raw_subprocess/.gitignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)