fix(board-db): sweep build.extra_flags across all enrichable boards (#298) (#312)

PR #299 unblocked FastLED CI for 3 priority nRF52840 boards by patching
their JSONs manually. This is the follow-up broader sweep: re-runs
enrich_boards (now with proper merge semantics) to restore
build.extra_flags on every board family fbuild already shipped without
the Arduino macros they need.

Changes:

* enrich_boards.rs: merge PIO-supplied build/upload fields into the
  existing fbuild JSON rather than wholesale replacing them. This
  preserves fbuild-only fields PIO no longer ships (e.g. legacy
  arduino.ldscript that PIO has moved into SCons builder scripts) while
  still picking up extra_flags, vid/pid, partitions, etc.
* 601 board JSONs touched across 16 platforms: intel_mcs51 (264),
  atmelsam (81), libretiny (47), nordicnrf52 (45), microchippic32 (39),
  espressif32 (35), nordicnrf51 (14), timsp430 (13),
  freescalekinetis (12), maxim32 (9), infineonxmc (8), ststm8 (8),
  lgt8f (7), nxpimxrt (6), nxplpc (6), siliconlabsefm32 (5). Most gain a
  full extra_flags string with ARDUINO_<BOARD> / NRF52840_XXAA / etc.
* tests: add test_nrf52840_sweep_arduino_macros covering the remaining
  Adafruit nRF52840 family (feather/clue/itsybitsy/metro/ledglasses/
  circuitplay) and test_non_nrf52_sweep_arduino_macros covering SAMD
  (zero/mkrzero/adafruit_feather_m0), 8051 (AT89S51), and PIC32
  (chipkit_uc32).

Validation:
* uv run python ci/validate_boards.py: 247 drift failures (down from
  817 on main) -- remaining "extra in our asset" entries are
  intentional fbuild-only fields (e.g. build.arduino.ldscript).
* soldr cargo check / clippy --workspace --all-targets -D warnings: pass
* bash ./test (full workspace): 0 failures across all crates

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

Author: zackees

crates/fbuild-config/assets/boards/json/4d_systems_esp32s3_gen4_r8n16.json

@@ -3,7 +3,7 @@
     "arduino": {
       "ldscript": "esp32s3_out.ld",
       "memory_type": "qio_opi",
-      "partitions": "default_16MB.csv"
+      "partitions": "esp_sr_16.csv"
     },
     "core": "esp32",
     "extra_flags": "-DARDUINO_ESP32_S3R8N16 -DBOARD_HAS_PSRAM -DARDUINO_USB_MODE=1 -DARDUINO_USB_CDC_ON_BOOT=1 -DARDUINO_RUNNING_CORE=1 -DARDUINO_EVENT_RUNNING_CORE=1",

crates/fbuild-config/assets/boards/json/96b_nitrogen.json

@@ -1,4 +1,8 @@
 {
+  "build": {
+    "f_cpu": "64000000L",
+    "mcu": "nrf52832"
+  },
   "connectivity": [
     "bluetooth"
   ],
@@ -19,6 +23,11 @@
   "platform": "nordicnrf52",
   "ram": 65536,
   "rom": 524288,
+  "upload": {
+    "maximum_ram_size": 65536,
+    "maximum_size": 524288,
+    "protocol": "jlink"
+  },
   "url": "https://www.96boards.org/product/nitrogen/",
   "vendor": "96Boards"
 }

crates/fbuild-config/assets/boards/json/AT89S51.json

@@ -1,4 +1,10 @@
 {
+  "build": {
+    "core": "naked",
+    "extra_flags": "-DAT89S51 -DNAKED_ARCH_MCS51 -DNAKED_MCS51_AT89S51",
+    "f_cpu": "11059200L",
+    "mcu": "at89s51"
+  },
   "fcpu": 11059200,
   "frameworks": [],
   "id": "AT89S51",
@@ -7,6 +13,11 @@
   "platform": "intel_mcs51",
   "ram": 128,
   "rom": 4096,
+  "upload": {
+    "maximum_ram_size": 128,
+    "maximum_size": 4096,
+    "protocol": "avrdude"
+  },
   "url": "https://www.microchip.com/wwwproducts/en/AT89S51",
   "vendor": "Microchip & Atmel"
 }

crates/fbuild-config/assets/boards/json/AT89S52.json

@@ -1,4 +1,10 @@
 {
+  "build": {
+    "core": "naked",
+    "extra_flags": "-DAT89S52 -DNAKED_ARCH_MCS51 -DNAKED_MCS51_AT89S52",
+    "f_cpu": "11059200L",
+    "mcu": "at89s52"
+  },
   "fcpu": 11059200,
   "frameworks": [],
   "id": "AT89S52",
@@ -7,6 +13,11 @@
   "platform": "intel_mcs51",
   "ram": 256,
   "rom": 8192,
+  "upload": {
+    "maximum_ram_size": 256,
+    "maximum_size": 8192,
+    "protocol": "avrdude"
+  },
   "url": "https://www.microchip.com/wwwproducts/en/AT89S52",
   "vendor": "Microchip & Atmel"
 }

crates/fbuild-config/assets/boards/json/CH559.json

@@ -1,4 +1,8 @@
 {
+  "build": {
+    "f_cpu": "12000000L",
+    "mcu": "ch559"
+  },
   "fcpu": 12000000,
   "frameworks": [],
   "id": "CH559",
@@ -7,6 +11,11 @@
   "platform": "intel_mcs51",
   "ram": 6400,
   "rom": 65536,
+  "upload": {
+    "maximum_ram_size": 6400,
+    "maximum_size": 65536,
+    "protocol": "ch55x"
+  },
   "url": "http://www.wch-ic.com/products/CH559.html",
   "vendor": "WCH"
 }

crates/fbuild-config/assets/boards/json/Generic8051.json

@@ -1,4 +1,10 @@
 {
+  "build": {
+    "core": "naked",
+    "extra_flags": "-DGeneric8051 -DNAKED_ARCH_MCS51 -DNAKED_MCS51_Generic8051",
+    "f_cpu": "11059200L",
+    "mcu": "8051"
+  },
   "fcpu": 11059200,
   "frameworks": [],
   "id": "Generic8051",
@@ -7,6 +13,10 @@
   "platform": "intel_mcs51",
   "ram": 128,
   "rom": 4096,
+  "upload": {
+    "maximum_ram_size": 128,
+    "maximum_size": 4096
+  },
   "url": "https://en.wikipedia.org/wiki/Intel_8051",
   "vendor": "Intel & Licensees"
 }

crates/fbuild-config/assets/boards/json/Generic8052.json

@@ -1,4 +1,10 @@
 {
+  "build": {
+    "core": "naked",
+    "extra_flags": "-DGeneric8052 -DNAKED_ARCH_MCS51 -DNAKED_MCS51_Generic8052",
+    "f_cpu": "11059200L",
+    "mcu": "8052"
+  },
   "fcpu": 11059200,
   "frameworks": [],
   "id": "Generic8052",
@@ -7,6 +13,10 @@
   "platform": "intel_mcs51",
   "ram": 256,
   "rom": 8192,
+  "upload": {
+    "maximum_ram_size": 256,
+    "maximum_size": 8192
+  },
   "url": "https://en.wikipedia.org/wiki/Intel_8051",
   "vendor": "Intel & licensees"
 }

crates/fbuild-config/assets/boards/json/IAP12C5A62S2.json

@@ -1,4 +1,11 @@
 {
+  "build": {
+    "core": "naked",
+    "extra_flags": "-DSTC12C5AXXS2 -DIAP12C5A62S2 -DNAKED_ARCH_MCS51 -DNAKED_MCS51_STC12C5AXXS2",
+    "f_cpu": "11059200L",
+    "mcu": "iap12c5a62s2",
+    "variant": "stc12c5axxS2"
+  },
   "fcpu": 11059200,
   "frameworks": [],
   "id": "IAP12C5A62S2",
@@ -7,6 +14,11 @@
   "platform": "intel_mcs51",
   "ram": 1280,
   "rom": 63488,
+  "upload": {
+    "maximum_ram_size": 1280,
+    "maximum_size": 63488,
+    "protocol": "stcgal"
+  },
   "url": "http://www.stcmicro.com/stc/stc12c5a32s2.html",
   "vendor": "STC"
 }

crates/fbuild-config/assets/boards/json/IAP15F106.json

@@ -1,4 +1,11 @@
 {
+  "build": {
+    "core": "naked",
+    "extra_flags": "-DSTC15F10X -DIAP15F106 -DNAKED_ARCH_MCS51 -DNAKED_MCS51_STC15F10X",
+    "f_cpu": "11059200L",
+    "mcu": "iap15f106",
+    "variant": "stc15f10x"
+  },
   "fcpu": 11059200,
   "frameworks": [],
   "id": "IAP15F106",
@@ -7,6 +14,11 @@
   "platform": "intel_mcs51",
   "ram": 128,
   "rom": 6144,
+  "upload": {
+    "maximum_ram_size": 128,
+    "maximum_size": 6144,
+    "protocol": "stcgal"
+  },
   "url": "http://www.stcmicro.com/STC/STC15F100.html",
   "vendor": "STC"
 }

crates/fbuild-config/assets/boards/json/IAP15F206A.json

@@ -1,4 +1,11 @@
 {
+  "build": {
+    "core": "naked",
+    "extra_flags": "-DSTC15F20XA -DIAP15F206A -DNAKED_ARCH_MCS51 -DNAKED_MCS51_STC15F20XA",
+    "f_cpu": "11059200L",
+    "mcu": "iap15f206a",
+    "variant": "stc15f20xa"
+  },
   "fcpu": 11059200,
   "frameworks": [],
   "id": "IAP15F206A",
@@ -7,6 +14,11 @@
   "platform": "intel_mcs51",
   "ram": 256,
   "rom": 6144,
+  "upload": {
+    "maximum_ram_size": 256,
+    "maximum_size": 6144,
+    "protocol": "stcgal"
+  },
   "url": "https://www.stcmicro.com/STC/STC15F204EA.html",
   "vendor": "STC"
 }