Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe Minimum Supported Rust Version (MSRV) is updated uniformly across the repository from 1.75 to 1.94.1. Changes encompass workflow configuration files, workspace package metadata, and development documentation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Investigation
The failing MSRV job was running Rust 1.75.0. It first failed while
soldrbootstrapped managedzccache, because the current zccache dependency graph includes crates using edition 2024, which Cargo 1.75 cannot parse. After bypassing that locally, the workspace dependency graph itself also contained crates requiring newer Rust, includingrunning-process-corewithrust-version = 1.85and other transitive dependencies requiring Rust 1.8x. Since this repo already pinsrust-toolchain.tomlto 1.94.1, this PR makes 1.94.1 the explicit MSRV.Verification
RUSTUP_TOOLCHAIN=1.94.1 uv run soldr cargo check --workspacegit diff --checkSummary by CodeRabbit