Skip to content

Avoid duplicate native release builds#187

Merged
zackees merged 1 commit intomainfrom
codex/native-build-dedupe
Apr 22, 2026
Merged

Avoid duplicate native release builds#187
zackees merged 1 commit intomainfrom
codex/native-build-dedupe

Conversation

@zackees
Copy link
Copy Markdown
Member

@zackees zackees commented Apr 22, 2026

Summary

  • Build fbuild-cli and fbuild-daemon in one Cargo invocation per native target.
  • Pass the explicit native target when building the PyO3 extension on macOS and Windows.
  • Stage macOS native/cross extensions from the explicit target directory.

Investigation

The linked Windows release job built binaries with --target x86_64-pc-windows-msvc, then entered the Python extension step. That extension command omitted --target on native Windows/macOS, so Cargo used the host output tree (target/release) after the binaries had populated target/<target>/release. On Windows this causes the shared graph to compile again. The binary step also used two separate Cargo invocations for fbuild-cli and fbuild-daemon, so this PR builds those together.

Verification

  • actionlint .github/workflows/template_native_build.yml
  • cargo check --target x86_64-pc-windows-msvc -p fbuild-cli -p fbuild-daemon with Rust 1.94.1 MSVC toolchain in an isolated temp target dir
  • cargo check --target x86_64-pc-windows-msvc -p fbuild-python --features extension-module with Rust 1.94.1 MSVC toolchain in an isolated temp target dir

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 22, 2026

Warning

Rate limit exceeded

@zackees has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 46 minutes and 45 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 46 minutes and 45 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ad2858c6-b1fe-496a-a2d9-d9952588e1f2

📥 Commits

Reviewing files that changed from the base of the PR and between c001800 and f7b4d58.

📒 Files selected for processing (1)
  • .github/workflows/template_native_build.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/native-build-dedupe

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees zackees merged commit b85edbc into main Apr 22, 2026
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant