teensy: prefer local FastLED over framework FastLED#198
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 59 minutes and 14 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
libraries/FastLEDeven when the project already provided a locallib/FastLEDsrc/,include/, andlib/over bundled framework headers with the same basename, while still allowing transitive framework dependencies likeSPI.hteensy30integration regression coverage for the locallib/FastLEDshadowing pathRoot Cause
This was not an
SPI.hheader conflict.The failure came from the Teensy framework-library selector building a basename map of bundled framework headers and treating the sketch's
#include <FastLED.h>as a request to compile the bundled frameworkFastLEDlibrary, even when the project already had its ownlib/FastLED/FastLED.h.That caused two independent build paths to compile FastLED into the same link:
lib/FastLED/...framework-arduinoteensy/.../libraries/FastLED/...SPI.honly shows up as a legitimate transitive dependency after local FastLED is selected.Testing
cargo test -p fbuild-build resolve_teensy_framework_libraries -- --nocapturecargo test -p fbuild-build --test teensy_build build_teensy30_fixture_prefers_local_fastled -- --ignored --nocaptureFixes #199.
Closes #195.