fix(fbuild-deploy): repair broken intra-doc links and fmt drift#201
fix(fbuild-deploy): repair broken intra-doc links and fmt drift#201
Conversation
- esp32_native.rs module-level `//!` docs use `crate::esp32::...` instead of `super::esp32::...`. Rustdoc does not resolve `super` from inner doc comments at the module file level under rustc 1.94.1, which broke `cargo doc --workspace --no-deps` with `RUSTDOCFLAGS=-D warnings`. Also fully qualify `VerifyOutcome` as `crate::esp32::VerifyOutcome` since it is not in scope at the module-doc resolution site. - esp32.rs: apply `cargo fmt` — the native-write early-return block had drifted out of the canonical layout. Fixes CI runs 24900888165 (Documentation) and 24900888192 (Formatting). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 53 minutes and 36 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes two CI jobs that failed at commit 2aa2e34 (Upgrade GitHub Actions to Node 24):
Documentation
soldr cargo doc --workspace --no-depswithRUSTDOCFLAGS=-D warningsfailed insidefbuild-deploywith fourrustdoc::broken-intra-doc-linkserrors, all in the module-level//!doc header ofcrates/fbuild-deploy/src/esp32_native.rs:Under rustc 1.94.1, rustdoc does not resolve
super::from inner doc comments (//!) at the top of a module file, andVerifyOutcomeis not in scope at the module-doc resolution site (theuse crate::esp32::{..., VerifyOutcome}lives further down in the file body). Fixed by switching to unambiguouscrate::esp32::...paths for all four links.Formatting
cargo fmt --all -- --checkcomplained about one block incrates/fbuild-deploy/src/esp32.rs:1245(thenative_write_or_fallbackearly-return aroundtry_deploy_native). Appliedcargo fmt. No other files touched.Test plan
cargo doc --workspace --no-depslocally withRUSTDOCFLAGS=-D warnings(rustc 1.94.1) — passescargo fmt --all -- --checklocally — passesDiff: 2 files, 8 insertions, 9 deletions. No behavior change, docs-only + whitespace.