ci(library-selection): #205 acceptance + bench workflows + bench/ stub#211
ci(library-selection): #205 acceptance + bench workflows + bench/ stub#211
Conversation
Wires the gates we already shipped into CI and stubs the warm-cache benchmark home that #205 calls for. No runtime changes. ## What ships ### CI workflows - `.github/workflows/acceptance-205.yml` — runs the `#[ignore]`'d Phase 6 gates from PR #208 (`teensylc_acceptance` + `stm32_acceptance`) on a manual trigger, nightly schedule, and PRs that touch resolver-affecting paths. 45-minute timeout per job; `fail-fast: false` so a teensy regression doesn't mask an stm32 one. - `.github/workflows/bench-205.yml` — runs the criterion benches from PR #210 (`scan_throughput` + `resolve_cold`) and uploads the HTML reports as 14-day artifacts. Manual + scoped-PR triggers; no CI threshold gates yet (P-02 / P-03 numbers captured for review until runner variance is characterized). ### `bench/fastled-examples/` stub - `bench/README.md` — top-level orientation. - `bench/fastled-examples/README.md` — placeholder for the warm-cache matrix benchmark called for by #205 P-01 / AC#5. Marked as awaiting Phase 4 (zccache K/V cache, gated on zackees/zccache#130) since there's no warm path to measure today. - `docs/INDEX.md` row added. ### Issue housekeeping - Closed #204 with a comment referencing PR #207 (foundation) + PR #208 (acceptance gate at `tests/teensylc_acceptance.rs`). - Commented on already-closed #202 noting the same resolution path for STM32 SPI auto-discovery. ## Verification - YAML files parse via `pyyaml.safe_load`. - Workflow paths-filters point at real files (`crates/fbuild-build/tests/{teensylc,stm32}_acceptance.rs`, the two `benches/*.rs` files). - `[[bench]]` names match `Cargo.toml` (`scan_throughput`, `resolve_cold`). ## Out of scope (still tracked) - Phase 4 — zccache K/V memoization (zackees/zccache#130). - P-01 (warm matrix) and P-04 (cache-hit) perf gates — depend on Phase 4. - CI threshold gates on P-02 / P-03 — wait for runner-variance data. - Phase 8.b — final `framework_libs.rs` cleanup once Phase 4 lands. - Baseline numeric capture (`tasks/baseline-205.md` placeholder; needs the new acceptance workflow to finish a successful nightly run). Refs: #202 (commented), #204 (closed), #205, zackees/zccache#130 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 13 minutes and 6 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Wires the gates already shipped (PR #208 acceptance + PR #210 benches) into CI, and stubs the warm-cache benchmark home #205 explicitly calls for.
What ships
Verification
Out of scope (still tracked)
Refs: #202 (commented), #204 (closed), #205, zackees/zccache#130
🤖 Generated with Claude Code