Skip to content

chore(deps): adopt upstream soldr/zccache/setup-soldr updates #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zackees merged 3 commits into from
May 22, 2026
Merged

chore(deps): adopt upstream soldr/zccache/setup-soldr updates #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d29481
chore(deps): adopt upstream soldr/zccache/setup-soldr updates
zackees May 22, 2026
1bd3b2b
ci(workflows): revert target-cache-profile -> target-cache: true
zackees May 22, 2026
2f7f1a3
ci(workflows): disable setup-soldr prebuild-deps (workaround upstream…
zackees May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/acceptance-205.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ jobs:
cache: true
build-cache: true
target-cache: true
prebuild-deps: none

- name: Run ${{ matrix.gate }} acceptance gate
run: |
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/bench-205.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ jobs:
cache: true
build-cache: true
target-cache: true
prebuild-deps: none

- name: "Run ${{ matrix.bench }} (target: ${{ matrix.target }})"
run: |
Expand Down Expand Up @@ -70,6 +71,7 @@ jobs:
cache: true
build-cache: true
target-cache: true
prebuild-deps: none

- name: Checkout FastLED
uses: actions/checkout@v6
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/check-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
cache: true
build-cache: true
target-cache: true
prebuild-deps: none

- name: Check
shell: bash
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/check-ubuntu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
cache: true
build-cache: true
target-cache: true
prebuild-deps: none

- name: Check
run: soldr cargo check --workspace --all-targets
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/check-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
cache: true
build-cache: true
target-cache: true
prebuild-deps: none

- name: Check
shell: bash
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
cache: true
build-cache: true
target-cache: true
prebuild-deps: none

- name: Build docs
run: soldr cargo doc --workspace --no-deps
1 change: 1 addition & 0 deletions .github/workflows/fmt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,6 @@ jobs:
cache: true
build-cache: true
target-cache: false
prebuild-deps: none
- name: Check formatting
run: soldr cargo fmt --all -- --check
1 change: 1 addition & 0 deletions .github/workflows/msrv.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
cache: true
build-cache: true
target-cache: true
prebuild-deps: none
toolchain: 1.94.1

- name: Check MSRV
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/template_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
cache: true
build-cache: true
target-cache: true
prebuild-deps: none
cache-key-suffix: board-${{ inputs.env-name }}

- name: Reset zccache daemon after cache warm
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/template_native_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ jobs:
cache: true
build-cache: true
target-cache: true
prebuild-deps: none
cache-key-suffix: native-${{ inputs.target }}

- uses: actions/setup-python@v6
Expand Down
51 changes: 45 additions & 6 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,17 @@ object = { version = "0.36", default-features = false, features = ["read", "std"
rusqlite = { version = "0.31", features = ["bundled"] }
shell-words = "1"
bincode = "1"
zccache-artifact = "1.4.0"
zccache-artifact = "1.8"
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

zccache-artifact 1.8 crates.io release notes

💡 Result:

I couldn’t find any crates.io “release notes” entry or changelog specifically for zccache-artifact v1.8 (e.g., “1.8.0” or “1.8.x”) in the sources I located. What I did find: - The crates.io page for the crate (overall listing) exists, but the version page details I found were for 1.3.8 and 1.3.9, not 1.8.x, and they don’t provide 1.8 release notes in the retrieved results. [1] - docs.rs for zccache_artifact describes the crate’s functionality (disk artifact cache, content-addressed storage, redb index), but it is API docs and not a versioned “1.8 release notes” changelog. [2] - GitHub compares I found are for tags like 1.3.8…1.3.9 and 1.4.7…1.4.8 (again not 1.8.x of zccache-artifact). [3][4] If you meant “zccache” (the overall project) v1.8.0 rather than the Rust crate “zccache-artifact” v1.8, the search results I saw were for PyPI zccache 1.8.0 (not crates.io release notes for zccache-artifact). [5] If you can share the exact version number you mean (e.g., zccache-artifact 1.8.0, 1.8.1, etc.) or a link to the crates.io version page, I can pull the release notes/changelog for that specific version.

Citations:

Fix dependency version: zccache-artifact = "1.8" appears not to exist on crates.io

  • Looked up results did not show any zccache-artifact 1.8.x version details/release notes; the available retrieved version pages were for zccache-artifact 1.3.8/1.3.9.
  • Update Cargo.toml (line 68) to the actually published zccache-artifact version, or provide the exact crates.io version/link (or confirm an alternate registry/source) if 1.8 is intentional.
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Cargo.toml` at line 68, The Cargo.toml currently references a non-existent
crate version for zccache-artifact ("1.8"); update the dependency declaration
for zccache-artifact to a published crates.io version (e.g., "1.3.9" or the
exact version you want), or if "1.8" is intentional, add/present the alternate
registry or git/source reference (and its exact URL/revision) so Cargo can
resolve it; locate the zccache-artifact entry in Cargo.toml and replace the
version string or add a registry/git specification accordingly.

rayon = "1"
tracing-test = "0.2"

# Process containment: all subprocess spawns the daemon performs (compilers,
# esptool, qemu, simavr, node, npm, …) and any grandchildren they fork must
# die with the daemon. Published to crates.io is pending; pin a git rev.
# See FastLED/fbuild#32.
# die with the daemon. Pinned to a pre-release rev that exposes the
# `Containment` enum / `spawn_with_containment` API. The published
# `running-process-core` 3.4.x dropped those in favor of
# `ContainedProcessGroup` — fbuild will need a containment-layer
# refactor before it can move to crates.io. See FastLED/fbuild#32.
running-process-core = { git = "https://github.com/zackees/running-process", rev = "ff9d7972504f7a0dcee0f410274daf3b02e4fcc2", package = "running-process-core" }

[profile.dev]
Expand Down
8 changes: 8 additions & 0 deletions crates/fbuild-build/tests/flag_escaping_lint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,19 @@ fn escaped_quote_usage_is_restricted() {

// These files are allowed to contain \\\" because they are the canonical
// sources/handlers of escaped-quote define values.
//
// Note: LOC-gate splits (refactor commits 5c90d0e/91f54e4/0cca5f3) moved
// canonical define code from board.rs / orchestrator.rs into submodule
// files (methods.rs, build.rs, mod.rs). Those are listed here too — they
// are still canonical define sources, just renamed.
let allowed_files: &[&str] = &[
"board.rs", // canonical define source with \\\"
"methods.rs", // canonical: split out of fbuild-config/src/board.rs (LOC gate)
"compiler.rs", // escaping module (prepare_flags_for_exec, write_response_file)
"esp32_framework.rs", // SDK defines parser (reads \\\" from disk)
"orchestrator.rs", // fallback define construction (same pattern as board.rs)
"build.rs", // canonical: split out of esp32/orchestrator.rs (LOC gate)
"mod.rs", // canonical: split out of stm32/orchestrator.rs (LOC gate)
"library_compiler.rs", // response file writer (checks for \\\" to skip double-quoting)
];

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ version = "2.2.3"
description = "PlatformIO-compatible embedded build tool (Rust implementation)"
readme = "README.md"
requires-python = ">=3.10"
dependencies = ["zccache>=1.2.13"]
dependencies = ["zccache>=1.8.2"]

[dependency-groups]
dev = ["fbuild-dev-tools"]
Expand Down
1 change: 1 addition & 0 deletions rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
[toolchain]
channel = "1.94.1"
profile = "minimal"
components = ["rustfmt", "clippy"]
16 changes: 8 additions & 8 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading