fix(lint): annotate Python daemon Command::new sites

[zackees]

Summary

After commit f86817a9 (refactor lib.rs -> submodules) the four std::process::Command::new sites in crates/fbuild-python/src/daemon.rs ended up inside match arms two lines below their // allow-direct-spawn: comment. The detector in ci/find_direct_subprocess.py only checks "same line or the line immediately above", so the annotation no longer covered the actual call sites and CI started reporting:

NEW direct spawns without an `allow-direct-spawn: <reason>` marker:
  crates/fbuild-python/src/daemon.rs:96
  crates/fbuild-python/src/daemon.rs:97
  crates/fbuild-python/src/daemon.rs:247
  crates/fbuild-python/src/daemon.rs:248

This blocks every PR's Lint subprocess spawns check — including #306 (the actual FastLED-vs-PIO size regression for fbuild#304).

Fix

Add an inline // allow-direct-spawn: daemon must outlive the Python interpreter. annotation immediately above each of the four match-arm Command::new calls. Behavior unchanged.

Verification

uv run python ci/find_direct_subprocess.py --fail
# Direct Command::new sites: 29
#   to migrate: 0
#   allowlisted: 29

Down from to migrate: 4 on main. Once this lands, PR #306's Lint subprocess spawns should turn green.

[coderabbitai]

Warning

Review limit reached

@zackees, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 38 minutes and 39 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fe0fc654-2506-46b6-a059-9b7a5189bd67

📥 Commits

Reviewing files that changed from the base of the PR and between 8f7910a and d8222ee.

📒 Files selected for processing (1)

• crates/fbuild-python/src/daemon.rs

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/lint-direct-spawn-annotation

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}